Merge pull request #338 from werf/fix-low-level-success-status-priori…

…tized-over-failure-2 fix(readiness): prioritize forced success status over failure /2
werf · Feb 28, 2024 · 7dddbbb · 7dddbbb
2 parents 72817a7 + 4d52ab2
commit 7dddbbb
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/pkg/trackers/dyntracker/dynamic_readiness_tracker.go b/pkg/trackers/dyntracker/dynamic_readiness_tracker.go
@@ -985,14 +985,14 @@ func (t *DynamicReadinessTracker) handleDeploymentStatus(status *deployment.Depl
 				rs.SetStatus(statestore.ResourceStatusReady)
 			})
 		}
+
+		return
 	}
 
 	if status.IsFailed {
 		taskState.ResourceState(taskState.Name(), taskState.Namespace(), taskState.GroupVersionKind()).RWTransaction(func(rs *statestore.ResourceState) {
 			rs.AddError(errors.New(status.FailedReason), "", time.Now())
 		})
-
-		return
 	}
 }
 
@@ -1011,14 +1011,14 @@ func (t *DynamicReadinessTracker) handleStatefulSetStatus(status *statefulset.St
 				rs.SetStatus(statestore.ResourceStatusReady)
 			})
 		}
+
+		return
 	}
 
 	if status.IsFailed {
 		taskState.ResourceState(taskState.Name(), taskState.Namespace(), taskState.GroupVersionKind()).RWTransaction(func(rs *statestore.ResourceState) {
 			rs.AddError(errors.New(status.FailedReason), "", time.Now())
 		})
-
-		return
 	}
 }
 
@@ -1037,14 +1037,14 @@ func (t *DynamicReadinessTracker) handleDaemonSetStatus(status *daemonset.Daemon
 				rs.SetStatus(statestore.ResourceStatusReady)
 			})
 		}
+
+		return
 	}
 
 	if status.IsFailed {
 		taskState.ResourceState(taskState.Name(), taskState.Namespace(), taskState.GroupVersionKind()).RWTransaction(func(rs *statestore.ResourceState) {
 			rs.AddError(errors.New(status.FailedReason), "", time.Now())
 		})
-
-		return
 	}
 }
 
@@ -1061,14 +1061,14 @@ func (t *DynamicReadinessTracker) handleJobStatus(status *job.JobStatus, taskSta
 				rs.SetStatus(statestore.ResourceStatusReady)
 			})
 		}
+
+		return
 	}
 
 	if status.IsFailed {
 		taskState.ResourceState(taskState.Name(), taskState.Namespace(), taskState.GroupVersionKind()).RWTransaction(func(rs *statestore.ResourceState) {
 			rs.AddError(errors.New(status.FailedReason), "", time.Now())
 		})
-
-		return
 	}
 }
 
@@ -1081,14 +1081,14 @@ func (t *DynamicReadinessTracker) handleCanaryStatus(status *canary.CanaryStatus
 				rs.SetStatus(statestore.ResourceStatusReady)
 			})
 		}
+
+		return
 	}
 
 	if status.IsFailed {
 		taskState.ResourceState(taskState.Name(), taskState.Namespace(), taskState.GroupVersionKind()).RWTransaction(func(rs *statestore.ResourceState) {
 			rs.AddError(errors.New(status.FailedReason), "", time.Now())
 		})
-
-		return
 	}
 }