Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are using Kubedog in our pipeline to watch rollouts and now we are moving to Flagger to have Canary Deployment but Kubedog doesn't support it.
Proposal
Since Flagger is a popular operator for Kubernetes, we would like to add support to Flagger Canary. The changes are isolated: we have created a new tracker specific for Canary so it won't impact in other resources.
My only concern is just about a custom specific configuration for Canary:
In a Canary deployment, we don't want to "keep trying" a rollout: if it fails, it must stop. Also I don't think it's a good idea to let people pass
AllowFailuresCount
because could lead a mistakes like eternal loopings.