Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Add Queue implementation #353

Merged
merged 2 commits into from
May 26, 2024
Merged

[rust] Add Queue implementation #353

merged 2 commits into from
May 26, 2024

Conversation

werkshy
Copy link
Owner

@werkshy werkshy commented Apr 11, 2024

As a user, I want to be able to add tracks, albums, etc to a queue and have them played in order. I want to be able to append tracks to the existing queue or replace the existing queue with new tracks.

  • Add Queue struct (server-side playlist)
  • Add API for adding tracks to the queue
  • Refactors::
    • Switch to only symphonia backends (can reverse this)
    • Add Factori and serial_tests for tests
    • Rename playlist to queue
    • Refactor Collection into struct so that we can add methods
    • Refactor CollectionBuilder into it's own module
    • Define 'all_tracks()' and 'get_tracks_under()' methods on Collection
    • Add JSON errors for e.g. 404
    • Add once_cell and refactor build_test_app to fix Sled locking problems

Todo in follow-up

  • Integrate Queue with player - have the Player just playing the tracks from the queue.

@werkshy werkshy force-pushed the add-playlist branch 3 times, most recently from d6e80de to 44c8a3b Compare May 26, 2024 14:22
@werkshy werkshy marked this pull request as ready for review May 26, 2024 14:26
- Add Queue struct
- Add API for adding tracks to the queue
- Refactors and collection navigation:
  - Switch to only symphonia backends (can reverse this)
  - Add Factori for tests
  - Rename playlist to queue
  - Refactor Collection into struct so that we can add methods
  - Refactor CollectionBuilder into it's own module
  - Define 'all_tracks()' and 'get_tracks_under()' methods on Collection
  - Add JSON errors for e.g. 404
  - Add once_cell and refactor build_test_app to fix Sled locking problems

TODO in follow-up
- Integrate Queue with player - have the Player just playing the tracks from the
queue.
@werkshy werkshy changed the title [rust] WIP add Playlist implementation [rust] Add Queue implementation May 26, 2024
@werkshy werkshy merged commit ce0aa71 into main May 26, 2024
2 checks passed
@werkshy werkshy deleted the add-playlist branch May 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant