Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct df7_10 road alignments according the changes to the EEA template #13

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Correct df7_10 road alignments according the changes to the EEA template #13

merged 4 commits into from
Aug 28, 2024

Conversation

annat2022
Copy link
Member

SVC-1872

@annat2022 annat2022 changed the title Correct df7_10 alignments according the changes to the EEA template Correct df7_10 road alignments according the changes to the EEA template Aug 15, 2024
florianesser
florianesser requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@florianesser florianesser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just noticed a couple of smaller things to fix before merging.

Also, the first line of the commit message feat(df7_10): implement check for max URL length starts with a space, that's why the commit message check failed.

Snippets/end.Checks.groovy Outdated Show resolved Hide resolved
Validation/MajorRoads/UBA-DE_HVS_to_END_DF7_10_Roads.halex.alignment.xml Outdated Show resolved Hide resolved
Validation/MajorRoads/UBA-DE_HVS_to_END_DF7_10_Roads.halex.alignment.xml Outdated Show resolved Hide resolved
Validation/MajorRoads/UBA-DE_HVS_to_END_DF7_10_Roads.halex.alignment.xml Outdated Show resolved Hide resolved
Validation/MajorRoads/UBA-DE_HVS_to_END_DF7_10_Roads.halex.alignment.xml Outdated Show resolved Hide resolved
@annat2022
Copy link
Member Author

Also, the first line of the commit message feat(df7_10): implement check for max URL length starts with a space, that's why the commit message check failed.

Thanks for the hint. I was already wondering why it is failing but missed that space...

florianesser
florianesser approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annat2022
refactor(df7_10): update Major Roads template schema
5503a52 
Implement the changes to the DF7_10 Major Railways Excel template in the
corresponding HSD JSON schema.

SVC-1872
@annat2022
feat(df7_10): implement check for max URL length
a0228fa 
Extend the `urlCheck` so that the maximum allowed length of a URL is checked.
The maximum length is configurable via the project variable `MAX_URL_LENGTH`.

SVC-1872
@annat2022
feat(df7_10): set freetext length limit to new value
08c7285 
Previously the limit was set to 10.000 characters. EEA updated this limit to
4.000 characters.

SVC-1872
@annat2022
feat(df7_10): implement changes to Major Roads alignments
8ae7bc6 
Implement changes required by the change of the DF7_10 Major Roads Excel
template.

SVC-1872
@annat2022 annat2022 merged commit e2352b2 into main Aug 28, 2024
1 check passed
@annat2022 annat2022 deleted the refactor/df7_10-changes-road branch August 28, 2024 07:30
@florianesser florianesser mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianesser florianesser florianesser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annat2022 @florianesser