Alignment df7 10 Roads #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianesser
approved these changes
May 10, 2024
Comment on lines
306
to
307
| def geplannteMaßnahmen = c.Maßnahmen.geplante.values() | ||
| def geplannteMaßnahmenNutzen = c.Maßnahmen.nutzen.value() |
There was a problem hiding this comment.
geplannte has an addtional n
There was a problem hiding this comment.
Thanks, for the hint. I fixed it now.
| publicConsultation_reviewExplanation( c.Öffentlichkeitsbeteiligung.lapUeberarbeitetKommentar.value() ) | ||
| } |
There was a problem hiding this comment.
Code style: wrong indentation of line 518
There was a problem hiding this comment.
Don't what was the issue here, because for me it looked correct in the groovy editor in hale studio.
But I removed and added the indentation with an editor and now it should be correct.
In case no planned measure is set and 'c.Maßnahmen.nutzen.value()' is empty a default value should be set. The respective changes are done here. SVC-1696
In case 'c.Öffentlichkeitsbeteiligung.lapUeberarbeitet.value()' is set to 'Nein' in the source data and 'c.Öffentlichkeitsbeteiligung.lapUeberarbeitetKommentar.value()' is empty a default value should be set for 'NoiseActionPlanMajorRoad.publicConsultation_reviewExplanation'. The respective changes are done here. SVC-1696
SVC-1696
annat2022
force-pushed
the
alignments_DF7_10
branch
from
e85d163
to
77075e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVC-1696