[Wv-581] implement learn more modal challenge invite friends #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just notices that constant loading was caused by this line : |
created BoostLearnMoreModal.jsx and added here src/js/common/components/ChallengeInviteFriends/BoostLearnMoreModal.jsx
…improved functionality
…improved functionality
itcreativeusa
force-pushed
the
wv-581-implement-learn-more-modal-challenge-invite-friends
branch
from
2395be4
to
5b88ce3
Compare
… changes based on meeting discussion - Following the meeting, made changes to the modal section as discussed. - Removed the unused PayToPromoteProcess import. - Uncommented the modal-related code to restore functionality.
…ge-invite-friends
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new component BoostLearnMoreModal.jsx from HelpWinOrDefeatModal.jsx.
Added import to ChallengeInviteSteps.jsx
ChallengeInviteSteps.jsx
Render BoostLearnMoreModal component within a Suspense wrapper to optimize loading
Added conditional rendering for BoostLearnMoreModal, ensuring it only shows when the showBoostLearnMoreModal state is true.
-Added the toggleBoostLearnMoreModal function to manage modal visibility by toggling showBoostLearnMoreModal state.
Added an onClick handler to trigger the modal visibility toggle when needed.
The original modal was not working to me - the modal remained constantly loaded.
After reviewing, I simplified the code by commenting a few lines and using basic divs. Now, the modal works, though there could be other underlying issues in the original code.
Here screenshots about it.