[WV-522] Created switcher for border in Joined and Days left #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iously were undefined, chanhed to correct ones and created switcher for border joined and days left Fixed DesignTokensColors in src/js/common/components/Challenge/JoinedAndDaysLeft.jsx as previously were undefined, changed to correct ones and created switcher for border joined and days left Renamed style prop to borderSwitcher in JoinedAndDaysLeft and ChallengeHeaderSimple components Applied borderswitcher for ChallengeHeaderSimple.jsx and change border:none to none as this is more correct and don't cause an error
itcreativeusa
changed the title
itcreativeusa
changed the title
itcreativeusa
changed the title
|
👍 Thank you @itcreativeusa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed design token colors to correct ones from file DesignTokenColors.js, and created a switcher for border joined and days left that turns off and on borderSwitcher={borderSwitcher} and borderSwitcher={False}
Fixed DesignTokensColors in JoinedAndDaysLeft.jsx as previously were undefined, changed to correct ones and created a switcher for border joined and days left
Renamed style prop to borderSwitcher in JoinedAndDaysLeft and ChallengeHeaderSimple components
Applied borderswitcher for ChallengeHeaderSimple.jsx and changed "border: none" to To just "none" in a ternary expression that dynamically applies CSS styles based on the value of the borderSwitcher prop.