Fixes for Cordova Android build 2.5.0.0 #4117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to get Sign in with Twitter working Some more removal of stripe calls. Some sneak fixes Removed a listener from OrganizationModal.jsx on close. "Fixed" the missing address on the ready page for mobile devices and Cordova.
DaleMcGrew
requested changes
Oct 17, 2024
| @@ -354,58 +345,58 @@ class PayToPromoteProcess extends Component { | |||
| </ContributeGridWrapper> | |||
| </InnerWrapper> | |||
| </OuterWrapper> | |||
| <PaymentWrapper> | |||
There was a problem hiding this comment.
Hi @SailingSteve we actually are using this code for a UX test and can't strip this out at this time. I'd rather leave PayToPromoteProcess untouched this close to the election. I'm happy to jump on a screenshare if you have any questions.
| @@ -380,16 +377,16 @@ class Donate extends Component { | |||
| </ContributeGridSection> | |||
| </ContributeGridWrapper> | |||
| <PaymentWrapper joining={joining}> | |||
| <PaymentCenteredWrapper> | |||
There was a problem hiding this comment.
I'd also like to leave this page unchanged this close to the election. This code shouldn't be reachable on our live site, but there are too many moving parts to make this change right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to get Sign in with Twitter working
Some more removal of stripe calls.
Some snyk fixes
Removed a listener from OrganizationModal.jsx on close.
"Fixed" the missing address on the ready page for mobile devices and Cordova.