TestScriptVerification - wv416 #4137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdiazq
reviewed
Oct 25, 2024
| const text4 = (await this.finePrintStepHeaderText4); | ||
| console.log("text4: " + text4); | ||
|
|
||
| await expect(text1).toHaveText('You cannot cast your vote electronically'); |
There was a problem hiding this comment.
Could you modify this test case to look if element is displayed instead of searching for secific text such as if id is present
fdiazq
requested changes
Oct 25, 2024
| @@ -24,7 +24,9 @@ class ReadyPage extends Page { | |||
| } | |||
|
|
|||
| get ballotAddress () { | |||
| return $('#ballotTitleBallotAddress'); | |||
| //return $('#ballotTitleBallotAddress'); | |||
| return $('//span[@class ="u-cursor--pointer u-link-color u-link-underline-on-hover"]'); | |||
There was a problem hiding this comment.
@shan14T For the locators that dont have id's could you add them in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made required changes to scripts after verification - wv416
What github.com/wevote/WebApp/issues does this fix?
wv416
Changes included this pull request?
changes to ReadyPage.js
changes to ready.page.js