Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MERGE READY] - WV-616 - Ballot Page: ADA - Not tabbing through 'Edit Address' #4239

Merged
merged 3 commits into from
Feb 5, 2025
Merged

[MERGE READY] - WV-616 - Ballot Page: ADA - Not tabbing through 'Edit Address' #4239

merged 3 commits into from
Feb 5, 2025

Conversation

eaw-pid
Copy link
Contributor

@eaw-pid eaw-pid commented Jan 31, 2025

I found a couple of options for tabbing over BallotAddress and opening the modal:

  1. Change BallotAddress in BallotTitleHeaderStyles.jsx to a 'button'
  2. Leave BallotAddress in BallotTitleHeaderStyles.jsx as a 'div' and include the onKeyDown in each BallotAddress div (more repetitive). I commented this one out in the pull request.

@eaw-pid eaw-pid changed the title [TEAM REVIEW] - WV-616 - Ballot Page: ADA - Not tabbing through 'Edit Address' [MERGE READY] - WV-616 - Ballot Page: ADA - Not tabbing through 'Edit Address' Feb 5, 2025
@DaleMcGrew
Copy link
Member

Thank you @eaw-pid! 👍

@DaleMcGrew DaleMcGrew merged commit 06859e1 into wevote:develop Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaw-pid @DaleMcGrew