Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were inspired by
hwinfo
s Makefile and by the GNU make manual.The current version detection system and the changelog are fully dependent on git. This complicates building from release archives. One of my commits adds the
LIBX86EMU_VERSION
variable that makes things simpler, but this is not a good solution in my opinion. Another solution to this problem is to add aVERSION
file that would be incremented on every release. This wouldn't change the logic that much since Makefile already usesVERSION
.And while we're here, I'll ask some questions: Is the
$(ARCH)
variable used for anything in the current version oflibx86emu
s Makefile and do you have any specific reason to use/usr/lib64
instead of/usr/lib
?