Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve Makefile #37

wants to merge 5 commits into from

Conversation

meator
Copy link
Contributor

@meator meator commented Aug 24, 2021

These changes were inspired by hwinfos Makefile and by the GNU make manual.

The current version detection system and the changelog are fully dependent on git. This complicates building from release archives. One of my commits adds the LIBX86EMU_VERSION variable that makes things simpler, but this is not a good solution in my opinion. Another solution to this problem is to add a VERSION file that would be incremented on every release. This wouldn't change the logic that much since Makefile already uses VERSION.

And while we're here, I'll ask some questions: Is the $(ARCH) variable used for anything in the current version of libx86emus Makefile and do you have any specific reason to use /usr/lib64 instead of /usr/lib?

@wfeldt
Copy link
Owner

wfeldt commented Aug 24, 2021

I'll take some time to look trough it all. So far:

  • I agree, the VERSION handling is not ideal; I've changed it a bit in some of my other projects
  • I don't really like .gitignore and I'd rather remove it instead of extending; IMHO a 'make clean' should leave the git repo in a clean state - so that git status looks nice
  • /usr/lib64 is the common location on 64 bit architectures - not on all, yes - but that's why the code tries to detect the situation
  • $ARCH is unused and can go - I believe it was used at some point for this lib64 decision

@meator
Copy link
Contributor Author

meator commented Aug 24, 2021

Thanks for your response! I'll remove the .gitignore commit.

@meator meator changed the title Improve Makefile and extend .gitignore Improve Makefile Aug 24, 2021
This commit adds some features mentioned in General Conventions for
Makefiles from the GNU make manual. It also allows the Makefile to
use some variables form the environment.
@wfeldt
Copy link
Owner

wfeldt commented Sep 6, 2021

Just a heads-up: I haven't forgotten...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants