Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect recursion for dir=auto special cases. #10561

Merged
merged 4 commits into from
Aug 21, 2024

Commits on Aug 15, 2024

  1. Fix incorrect recursion for dir=auto special cases.

    dir=auto has special-case behavior for both (1) auto-directionality
    form-associated elements and (2) slots with assigned nodes.  In these
    special cases dir=auto is intended to have special behavior when used on
    the element, but this special behavior was not intended to apply when
    dir=auto was used on an ancestor.
    
    The wording in the HTML spec for this behavior got this incorrect for at
    least one case, where the handling of the slot case needs recursion over
    the assigned nodes as though they were descendants.  This was uncovered
    by the Gecko implementor adding a test for this case as described in
    https://bugzilla.mozilla.org/show_bug.cgi?id=1876163#c13 .  I believe
    this was a mistake in the spec and should be fixed.
    dbaron committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    21867f8 View commit details
    Browse the repository at this point in the history
  2. Also fix the exclusion clause.

    dbaron committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e9dd789 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    9bbe199 View commit details
    Browse the repository at this point in the history
  2. Also use data-x.

    dbaron committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2049e18 View commit details
    Browse the repository at this point in the history