Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: use 'global' rather than 'this' in timer initialization steps #10647

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Ms2ger
Copy link
Member

@Ms2ger Ms2ger commented Sep 26, 2024

There is no this value around at this point.

(See WHATWG Working Mode: Changes for more details.)


/timers-and-user-prompts.html ( diff )

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you also fix the other instance three steps down?

(Tiny bit on the fence as to whether this is editorial, but I suppose it's somewhat hard to misunderstand intent.)

@Ms2ger
Copy link
Member Author

Ms2ger commented Sep 26, 2024

Done, thanks for catching that. I don't mind much either way about calling it editorial.

@annevk annevk merged commit b8ea975 into main Sep 26, 2024
2 checks passed
@annevk annevk deleted the timer-init-this branch September 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants