Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify WebDriver BiDi about "committed" navigations #10910

Merged
merged 9 commits into from
Jan 31, 2025
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -4592,12 +4592,14 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li><dfn data-x="navigation-status-id" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-id">navigation status id</dfn></li>
<li><dfn data-x="navigation-status-status" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-status">navigation status status</dfn></li>
<li><dfn data-x="navigation-status-canceled" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-canceled">navigation status canceled</dfn></li>
<li><dfn data-x="navigation-status-committed" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-committed">navigation status committed</dfn></li>
<li><dfn data-x="navigation-status-pending" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-pending">navigation status pending</dfn></li>
<li><dfn data-x="navigation-status-complete" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-complete">navigation status complete</dfn></li>
<li><dfn data-x="navigation-status-url" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-url">navigation status url</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-started">WebDriver BiDi navigation started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-aborted">WebDriver BiDi navigation aborted</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-committed">WebDriver BiDi navigation committed</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-failed">WebDriver BiDi navigation failed</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-started">WebDriver BiDi navigation started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-download-started">WebDriver BiDi download started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-fragment-navigated">WebDriver BiDi fragment navigated</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-dom-content-loaded">WebDriver BiDi DOM content loaded</dfn></li>
Expand Down Expand Up @@ -102097,17 +102099,33 @@ location.href = '#foo';</code></pre>
<li>
<p>Otherwise, if <var>navigationParams</var>'s <span
data-x="navigation-params-response">response</span>'s <span
data-x="concept-response-status">status</span> is not 204 and is not 205, then set
<var>entry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-document">document</span> to the result of <span>loading a
document</span> given <var>navigationParams</var>, <var>sourceSnapshotParams</var>, and
<var>entry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-initiator-origin">initiator origin</span>.</p>
data-x="concept-response-status">status</span> is not 204 and is not 205, then:</p>

<p class="note">This can result in setting <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-document">document</span> to null, e.g., when <span data-x="hand-off
to external software">handing-off to external software</span>.</p>
<ol>
<li>
<p>Set <var>entry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-document">document</span> to the result of <span>loading a
document</span> given <var>navigationParams</var>, <var>sourceSnapshotParams</var>, and
<var>entry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-initiator-origin">initiator origin</span>.</p>

<p class="note">This can result in setting <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-document">document</span> to null, e.g., when <span
data-x="hand-off to external software">handing-off to external software</span>.</p>
</li>

<li><p>Invoke <span>WebDriver BiDi navigation committed</span> with <var>navigable</var> and
a new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>document</var>'s <span
data-x="concept-document-navigation-id">during-loading navigation ID for WebDriver
BiDi</span>, <span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-committed">comitted</code>", and <span
data-x="navigation-status-url">url</span> is <var>document</var>'s <span
data-x="concept-document-url">URL</span> if <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-document">document</span> is not null.</p></li>
OrKoN marked this conversation as resolved.
Show resolved Hide resolved
</ol>
</li>

<li>
Expand Down