Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify WebDriver BiDi about "committed" navigations #10910

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Notify WebDriver BiDi about "committed" navigations #10910

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7641acb
Navigation comitted
OrKoN Jan 13, 2025
54217df
fix indent
OrKoN Jan 15, 2025
d7902b0
run specfmt
OrKoN Jan 15, 2025
80caa5a
move to step 6
OrKoN Jan 16, 2025
57a4cbc
put if first
OrKoN Jan 23, 2025
0b16f61
move integration to update document for history step application
OrKoN Jan 27, 2025
4f82379
check if during-loading navigation ID for WebDriver BiDi is not null
OrKoN Jan 27, 2025
89dec32
change to assertion
OrKoN Jan 30, 2025
90a0681
Fix indent and rewrap
domenic Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4592,12 +4592,14 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li><dfn data-x="navigation-status-id" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-id">navigation status id</dfn></li>
<li><dfn data-x="navigation-status-status" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-status">navigation status status</dfn></li>
<li><dfn data-x="navigation-status-canceled" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-canceled">navigation status canceled</dfn></li>
<li><dfn data-x="navigation-status-committed" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-committed">navigation status committed</dfn></li>
<li><dfn data-x="navigation-status-pending" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-pending">navigation status pending</dfn></li>
<li><dfn data-x="navigation-status-complete" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-complete">navigation status complete</dfn></li>
<li><dfn data-x="navigation-status-url" data-x-href="https://w3c.github.io/webdriver-bidi/#navigation-status-url">navigation status url</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-started">WebDriver BiDi navigation started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-aborted">WebDriver BiDi navigation aborted</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-committed">WebDriver BiDi navigation committed</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-failed">WebDriver BiDi navigation failed</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-navigation-started">WebDriver BiDi navigation started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-download-started">WebDriver BiDi download started</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-fragment-navigated">WebDriver BiDi fragment navigated</dfn></li>
<li><dfn data-x-href="https://w3c.github.io/webdriver-bidi/#webdriver-bidi-dom-content-loaded">WebDriver BiDi DOM content loaded</dfn></li>
Expand Down Expand Up @@ -104294,9 +104296,22 @@ location.href = '#foo';</code></pre>
</li>

<li>
<p>If <var>documentIsNew</var> is true, then:
<p>If <var>documentIsNew</var> is true, then:</p>
domenic marked this conversation as resolved.
Show resolved Hide resolved

<ol>
<li><p><span>Assert</span>: <var>document</var>'s <span
domenic marked this conversation as resolved.
Show resolved Hide resolved
data-x="concept-document-navigation-id">during-loading navigation ID for WebDriver BiDi</span>
is not null.</p></li>

<li><p>Invoke <span>WebDriver BiDi navigation committed</span> with <var>navigable</var> and a
new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>document</var>'s <span
data-x="concept-document-navigation-id">during-loading navigation ID for WebDriver BiDi</span>,
<span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-committed">comitted</code>", and <span
data-x="navigation-status-url">url</span> is <var>document</var>'s <span
data-x="concept-document-url">URL</span></p></li>

<li><p><span>Try to scroll to the fragment</span> for <var>document</var>.</p></li>

<li><p>At this point <dfn>scripts may run for the newly-created document</dfn>
Expand Down