Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make togglePopover throw more exceptions #9451

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Jun 21, 2023

This PR makes sure that togglePopover will throw exceptions when it is disconnected from the document or doesn't have a popover attribute.

Fixes #8999

(See WHATWG Working Mode: Changes for more details.)


/popover.html ( diff )

This PR makes sure that togglePopover will throw exceptions when it is
disconnected from the document or doesn't have a popover attribute.

Fixes whatwg#8999
@nt1m
Copy link
Member

nt1m commented Jun 24, 2023

Looks ok to me, @annevk what do you think?

@nt1m nt1m added the topic: popover The popover attribute and friends label Jun 24, 2023
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and thanks for addressing! Please complete the checkboxes in OP and address the nit.

source Show resolved Hide resolved
@nt1m
Copy link
Member

nt1m commented Jun 28, 2023

(there's already a WebKit bug so no need to file one: https://bugs.webkit.org/show_bug.cgi?id=258574)

@josepharhar
Copy link
Contributor Author

Please complete the checkboxes in OP and address the nit.

done

@annevk annevk merged commit be5c890 into whatwg:main Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: popover The popover attribute and friends
3 participants