Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore DOM state when hiding popovers if needed #9457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ignore DOM state when hiding popovers if needed #9457

wants to merge 3 commits into from

Commits on Jun 26, 2023

  1. Ignore DOM state when hiding popovers if needed 

    Fixes whatwg#9161
Fixes whatwg#9367
Makes obsolete whatwg/dom#1185

This PR prevents the hide popover algorithm from returning early when
the popover attribute is removed or when the element with the popover
attribute is removed from the document.

The fireEvents parameter is used as an indicator that either the element
is being removed or that the attribute is being removed, and when it is
false, the calls to check popover validity are replaced with a check to
simply see if the popover is already hidden.

This patch also makes removal of the popover attribute stop firing
events in order to signal to the hide popover algorithm that checks for
the popover attribute should be ignored.
    @josepharhar
    josepharhar committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f60c3a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. make removeattribute start firing events again

    @josepharhar
    josepharhar committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    acbbfdb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. fix args

    @josepharhar
    josepharhar committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d683a6b View commit details
    Browse the repository at this point in the history