Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with css-view-transitions-1 #9524

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Integration with css-view-transitions-1 #9524

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bfaeba
Upstream css-view-transitions-1 monkey-patches
noamr Jul 17, 2023
3a8ea84
nit
noamr Jul 17, 2023
362330d
Remove version number
noamr Jul 18, 2023
13897ef
Remove version from biblio
noamr Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3988,6 +3988,14 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li>The <dfn data-x-href="https://drafts.csswg.org/css-values/#math-function">math functions</dfn></li>
</ul>

<p>The following features are defined in <cite>CSS View Transitions 1</cite>: <ref
spec=CSSVIEWTRANSITIONS1></p>

<ul class="brief">
<li><dfn data-x-href="https://drafts.csswg.org/css-view-transitions-1/#perform-pending-transition-operations">perform pending transition operations</dfn></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere, use the unversioned URLs (no -1).

Also, it's common practice so far to omit the version numbers from our hand-curated bibliographies, so in the <cite> and bibliography, just say CSS View Transitions. And rename the spec slug to CSSVIEWTRANSITIONS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<li><dfn data-x-href="https://drafts.csswg.org/css-view-transitions-1/#document-rendering-suppression-for-view-transitions">rendering suppression for view transitions</dfn></li>
</ul>

<p>The term <dfn data-x="css-styling-attribute"
data-x-href="https://drafts.csswg.org/css-style-attr/#style-attribute">style attribute</dfn> is
defined in <cite>CSS Style Attributes</cite>. <ref spec=CSSATTR></p>
Expand Down Expand Up @@ -106250,11 +106258,12 @@ import "https://example.com/foo/../module2.mjs";</code></pre>

<p>A <span>navigable</span> has no <span data-x="rendering opportunity">rendering
opportunities</span> if its <span data-x="nav-document">active document</span> is
<span>render-blocked</span>; otherwise, <span data-x="rendering opportunity">rendering
opportunities</span> are determined based on hardware constraints such as display refresh
rates and other factors such as page performance or whether the document's <span>visibility
state</span> is "<code data-x="">visible</code>". Rendering opportunities typically occur at
regular intervals.</p>
<span>render-blocked</span> or if it is <span
data-x="rendering suppression for view transitions">suppressed for view transitions</span>;
otherwise, <span data-x="rendering opportunity">rendering opportunities</span> are determined
based on hardware constraints such as display refresh rates and other factors such as page
performance or whether the document's <span>visibility state</span> is "<code
data-x="">visible</code>". Rendering opportunities typically occur at regular intervals.</p>

<p class="note">This specification does not mandate any particular model for selecting
rendering opportunities. But for example, if the browser is attempting to achieve a 60Hz
Expand Down Expand Up @@ -106419,7 +106428,11 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
data-x="event-change">change</code> events.</p>
</li>

<li><p>For each <span>fully active</span> <code>Document</code> in <var>docs</var>, <span>run
<li><p>For each <span>fully active</span> <code>Document</code> in <var>docs</var>,
<span>perform pending transition operations</span> for that <code>Document</code>. <ref
spec=CSSVIEWTRANSITIONS1></p></li>

<li><p>For each <span>fully active</span> <code>Document</code> in <var>docs</var>, <span>run
the update intersection observations steps</span> for that <code>Document</code>, passing in
<var>now</var> as the timestamp. <ref spec=INTERSECTIONOBSERVER></p></li>

Expand Down Expand Up @@ -138150,6 +138163,9 @@ INSERT INTERFACES HERE
<dt id="refsCSSVALUES">[CSSVALUES]</dt>
<dd><cite><a href="https://w3c.github.io/csswg-drafts/css-values/">CSS3 Values and Units</a></cite>, H. Lie, T. Atkins, E. Etemad. W3C.</dd>

<dt id="refsCSSVIEWTRANSITIONS1">[CSSVIEWTRANSITIONS1]</dt>
<dd><cite><a href="https://drafts.csswg.org/css-view-transitions-1/">CSS View Transitions Module Level 1</a></cite>, T. Atkins Jr.; J. Archibald; K Sagar. W3C.</dd>

<dt id="refsCSSUI">[CSSUI]</dt>
<dd><cite><a href="https://w3c.github.io/csswg-drafts/css-ui/">CSS3 Basic User Interface Module</a></cite>, F. Rivoal. W3C.</dd>

Expand Down