Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-fetch-scheme-params-initiator-origin assignment #9532

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix non-fetch-scheme-params-initiator-origin assignment #9532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98195,11 +98195,18 @@ location.href = '#foo';</code></pre>
data-x="policy-container-csp-list">CSP list</span>'s <span>CSP-derived sandboxing
flags</span>.</p></li>

<li><p>Set <var>responseOrigin</var> to the result of <span>determining the origin</span>
given <var>response</var>'s <span data-x="concept-response-url">URL</span>,
<var>finalSandboxFlags</var>, and <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-initiator-origin">initiator origin</span>.</p></li>
<li>
<p>Set <var>responseOrigin</var> to the result of <span>determining the origin</span> given
<var>response</var>'s <span data-x="concept-response-url">URL</span>,
<var>finalSandboxFlags</var>, and <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-initiator-origin">initiator origin</span>.</p>

<p class="note">If <var>response</var> is a redirect, then <var>response</var>'s <span
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the OP for this. If this note is too heavy on the documentation let me know and I'll remove it, but since I have to think this through every time I read this algorithm, I figured it could be helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the only part of the platform that manually handles redirects, I think it's very reasonable to include this sort of thing.

data-x="concept-response-url">URL</span> will be the URL that led to the redirect to
<var>response</var>'s <span data-x="concept-response-location-url">location URL</span>; it
will not be the <span data-x="concept-response-location-url">location URL</span> itself.</p>
</li>

<li>
<p>If <var>navigable</var> is a <span>top-level traversable</span>, then:</p>
Expand Down Expand Up @@ -98410,7 +98417,7 @@ location.href = '#foo';</code></pre>
transient activation</span></dd>

<dt><span data-x="non-fetch-scheme-params-initiator-origin">initiator origin</span></dt>
<dd><span data-x="concept-url-origin">origin</span></dd>
<dd><var>responseOrigin</var></dd>

<dt><span data-x="non-fetch-scheme-params-nav-timing-type">navigation timing type</span></dt>
<dd><var>navTimingType</var></dd>
Expand Down