Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and exemplify non-normative changes #225

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 30, 2024

The previous text implied that non-normative changes were the same as editorial changes. At least using the definition of "editorial" in https://github.com/whatwg/meta/blob/main/COMMITTING.md#title-prefixes, this is not correct; non-normative changes are a superset of editorial changes.

Kudos to @jeremyroman for pointing this out.

The previous text implied that non-normative changes were the same as editorial changes. At least using the definition of "editorial" in https://github.com/whatwg/meta/blob/main/COMMITTING.md#title-prefixes, this is not correct; non-normative changes are a superset of editorial changes.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a caveat here we might want to point out if we're going to clarify. That is when implementations are in conflict there probably should be a wider discussion.

@domenic
Copy link
Member Author

domenic commented Jan 31, 2024

Added a note to that effect!

@annevk annevk requested review from tantek, cwilso and diekus February 1, 2024 10:08
Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwilso cwilso merged commit 4b00e3c into main Feb 6, 2024
1 check passed
@cwilso cwilso deleted the clarify-non-normative-changes branch February 6, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants