Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frag ids for stages #233

Merged
merged 4 commits into from
Apr 29, 2024
Merged

frag ids for stages #233

merged 4 commits into from
Apr 29, 2024

Conversation

tantek
Copy link
Member

@tantek tantek commented Apr 26, 2024

IDs for stages in the table to enable to direct linking to a specific stage

IDs for stages in the table to enable to direct linking to a specific stage
@tantek tantek requested a review from cwilso April 26, 2024 16:36
@annevk
Copy link
Member

annevk commented Apr 26, 2024

I think the IDs should be on the <tr>. And we should add self-links as well I guess as people might want to have access to these?

Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @annevk the IDs should be on the TRs, committed change

tantek added 2 commits April 26, 2024 14:23
agreed and fixed one more
Added self-links similar to https://whatwg.org/faq source (good suggestion @annevk), and a missing <br> to the "Stage 4" cell consistent with the other Stage cells.
@tantek tantek requested review from cwilso and annevk April 26, 2024 21:36
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Looks like the required style sheet adjustment is trivial too.

@annevk annevk merged commit 223c7eb into main Apr 29, 2024
1 check passed
@annevk annevk deleted the tantek-patch-2 branch April 29, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants