Editorial: Use CreateDataPropertyOrThrow abstract op in more places #1359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step like
! CreateDataProperty(...)
asserts only that[[DefineOwnProperty]]
is an ordinary method that can't throw, but doesn't assert that property creation is a guaranteed success because[[DefineOwnProperty]]
only returns boolean status (it isObject.defineProperty
that throws aTypeError
).This change replaces these steps with
! CreateDataPropertyOrThrow(...)
, asserting that property is defined successfully since all its call sites operate on newly-created objects with no non-configurable properties.ECMA-262 has no occurrences of
! CreateDataProperty(...)
.Also, this change replaces "Call" with "Perform", which is a new convention of ECMA-262.
Preview | Diff