Editorial: Refer to ECMA-262 as JavaScript rather than ECMAScript #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Dec 21, 2023
index.bs
Outdated
| @@ -1533,7 +1535,7 @@ on which they appear. It is language binding specific whether | |||
| }; | |||
| </pre> | |||
|
|
|||
| the constant value can be accessed in ECMAScript either as | |||
| the constant value can be accessed in JavaScript either as | |||
There was a problem hiding this comment.
Suggested change
| the constant value can be accessed in JavaScript either as | |
| the constant value can be accessed in JavaScript either as |
| @@ -6964,11 +6967,11 @@ to its caller, and so on. | |||
| </div> | |||
|
|
|||
|
|
|||
| <h3 id="es-environment">ECMAScript environment</h3> | |||
| <h3 id="js-environment" oldids="es-environment">JavaScript environment</h3> | |||
There was a problem hiding this comment.
I think keeping the old IDs and not adding new IDs would be fine as well. I personally prefer that as it shows the document has some history.
There was a problem hiding this comment.
There's some history of using oldids (e.g., adding es-undefined and adding es-void as an old ID, when WebIDL renamed the concept of void). If the consensus is that we should continue to use es- for IDs then I can unwind that, though.
|
We should add "Fixes #863." to the end of the final commit message. (Seems PR Preview won the race a couple times there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with how the HTML Living Standard, also a a WHATWG work product, refers to it and is how most developers would be familiar with it.
Included in this change:
Fixes #863.
Preview | Diff