-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for global objects with a mutable prototype chain #1381
Conversation
This is required to define the ShadowRealm global object in IDL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, pretty close now. (I'm trusting the JS bits as you probably know that better than me.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give some time for others to comment, but to me this seems good to go.
I guess there's a question of how much we want to wait for implementer interest for an infrastructure change. @domenic thoughts?
In general I'm supportive of not waiting too much. (E.g. it seems annoying to me that #1353 is stalled on that.) But the overall fate of ShadowRealm seems a bit unclear to me, given its regression to stage 2, so I'm a bit hesitant about making a bunch of ShadowRealm-related changes to our specs. But, it's probably fine, as long as we're good about reverting if a proposal gets withdrawn. That's what we did for, e.g., #924. |
ShadowRealms was reverted to stage 2 because the web-side specifications were not ready; this PR is one of the blockers to advance to stage 3 again. |
@Ms2ger would you be willing to file the implementation bugs for this and update OP afterwards? I'm thinking primarily of the tooling-related projects. Browsers will get there as part of ShadowRealm. |
This is required to define the ShadowRealm global object in IDL.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff