Export "an exception was thrown" #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Mar 14, 2024
| @@ -14589,7 +14589,8 @@ must propagate to the caller, and if | |||
| not caught there, to its caller, and so on. | |||
|
|
|||
| Per [[#conventions]], an algorithm specified in this document may intercept thrown exceptions, either by specifying | |||
| the exact steps to take if <dfn>an exception was thrown</dfn>, or by explicitly handling [=abrupt completions=]. | |||
| the exact steps to take if <dfn export>an exception was thrown</dfn>, or by explicitly handling | |||
| [=abrupt completions=]. | |||
There was a problem hiding this comment.
You'll have to change more of the wording here if you want this to be generally useful ("in this document" makes it not work).
However, we also define this in https://infra.spec.whatwg.org/#algorithm-control-flow and I suspect we want to centralize on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in other specifications, which have to manually bring in the un-exported definition: https://github.com/WICG/shared-storage/pull/131/files#diff-6f5a1d8263b0b0c42e2716ba5750e3652e359532647ac934c1c70086ae3ceddaR23-R24. It seems useful to allow other specifications to hook into this though.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff