Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: update repository files #385

Merged
merged 4 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ max_line_length = 100
[Makefile]
indent_style = tab

[*.md]
max_line_length = off

[*.bs]
indent_size = 1

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
name: Build

on:
pull_request:
branches:
- main
push:
branches:
- main
workflow_dispatch:

jobs:
build:
name: Build
Expand All @@ -17,6 +20,7 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: "3.11"
- run: pip install bikeshed && bikeshed update
# Note: `make deploy` will do a deploy dry run on PRs.
- run: make deploy
env:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ remote: xhr.bs
);

local: xhr.bs
bikeshed spec xhr.bs xhr.html --md-Text-Macro="COMMIT-SHA LOCAL COPY"
bikeshed spec xhr.bs xhr.html --md-Text-Macro="COMMIT-SHA LOCAL-COPY"

deploy: xhr.bs
curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh
Expand Down
35 changes: 18 additions & 17 deletions xhr.bs
Original file line number Diff line number Diff line change
Expand Up @@ -283,13 +283,13 @@ constructor steps are:
<i>headers received</i>, or <i>loading</i>, and it has one or more
<a>event listeners</a>
registered whose <b>type</b> is one of
<a event><code>readystatechange</code></a>,
<a event><code>progress</code></a>,
<a event><code>abort</code></a>,
<a event><code>error</code></a>,
<a event><code>load</code></a>,
<a event><code>timeout</code></a>, and
<a event><code>loadend</code></a>.
{{XMLHttpRequest/readystatechange}},
{{XMLHttpRequest/progress}},
{{XMLHttpRequest/abort}},
{{XMLHttpRequest/error}},
{{XMLHttpRequest/load}},
{{XMLHttpRequest/timeout!!event}}, and
{{XMLHttpRequest/loadend}}.
<!-- No need to mention upload event listeners as they happen during /opened/. -->

<p>If an {{XMLHttpRequest}} object is garbage collected while its connection is still open, the user
Expand All @@ -313,25 +313,25 @@ from {{XMLHttpRequestEventTarget}} as attributes:
<tbody>
<tr>
<td><dfn id=handler-xhr-onloadstart attribute for=XMLHttpRequestEventTarget><code>onloadstart</code></dfn>
<td><a event><code>loadstart</code></a>
<td>{{XMLHttpRequest/loadstart}}
<tr>
<td><dfn id=handler-xhr-onprogress attribute for=XMLHttpRequestEventTarget><code>onprogress</code></dfn>
<td><a event><code>progress</code></a>
<td>{{XMLHttpRequest/progress}}
<tr>
<td><dfn id=handler-xhr-onabort attribute for=XMLHttpRequestEventTarget><code>onabort</code></dfn>
<td><a event><code>abort</code></a>
<td>{{XMLHttpRequest/abort}}
<tr>
<td><dfn id=handler-xhr-onerror attribute for=XMLHttpRequestEventTarget><code>onerror</code></dfn>
<td><a event><code>error</code></a>
<td>{{XMLHttpRequest/error}}
<tr>
<td><dfn id=handler-xhr-onload attribute for=XMLHttpRequestEventTarget><code>onload</code></dfn>
<td><a event><code>load</code></a>
<td>{{XMLHttpRequest/load}}
<tr>
<td><dfn id=handler-xhr-ontimeout attribute for=XMLHttpRequestEventTarget><code>ontimeout</code></dfn>
<td><a event><code>timeout</code></a>
<td>{{XMLHttpRequest/timeout!!event}}
<tr>
<td><dfn id=handler-xhr-onloadend attribute for=XMLHttpRequestEventTarget><code>onloadend</code></dfn>
<td><a event><code>loadend</code></a>
<td>{{XMLHttpRequest/loadend}}
</table>

<p>The following is the
Expand Down Expand Up @@ -1029,11 +1029,12 @@ return <a>this</a>'s <a>cross-origin credentials</a>.

<li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a>'s
<a for=response>aborted flag</a> is set, run the <a>request error steps</a> for <var>xhr</var>,
<a event><code>abort</code></a>, and "{{AbortError!!exception}}" {{DOMException}}.
<a event for=XMLHttpRequest><code>abort</code></a>, and "{{AbortError!!exception}}"
{{DOMException}}.

<li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a> is a
<a for=/>network error</a>, then run the <a>request error steps</a> for <var>xhr</var>,
<a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}.
{{XMLHttpRequest/error}}, and "{{NetworkError!!exception}}" {{DOMException}}.
</ol>

<p>The <dfn>request error steps</dfn> for an {{XMLHttpRequest}} object <var>xhr</var>,
Expand Down Expand Up @@ -1093,7 +1094,7 @@ return <a>this</a>'s <a>cross-origin credentials</a>.

<li><p>If <a>this</a>'s <a>state</a> is <i>opened</i> with <a>this</a>'s
<a><code>send()</code> flag</a> set, <i>headers received</i>, or <i>loading</i>, then run the
<a>request error steps</a> for <a>this</a> and <a event><code>abort</code></a>.
<a>request error steps</a> for <a>this</a> and <a event for=XMLHttpRequest><code>abort</code></a>.

<li>
<p>If <a>this</a>'s <a>state</a> is <i>done</i>, then set <a>this</a>'s <a>state</a> to
Expand Down