Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set connection transport buffer for active socket #363

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

kennethito
Copy link
Contributor

fixes #362

@whatyouhide
Copy link
Owner

@kennethito thank you so much for the PR! However, there's one thing we need to tweak. Right now, there are socket options that we let the user customize (say, the SSL opts) and options that we force (like active: :once). I think this buffer size option should be one that we let the user customize, falling back to a default of 1_000_000 as seen in this PR. Thoughts?

@kennethito kennethito force-pushed the feature/transport-buffer branch 2 times, most recently from 071382a to 40320ca Compare April 16, 2024 15:55
@kennethito
Copy link
Contributor Author

@whatyouhide Ah, didn't notice the existing transport options. Updated!

@whatyouhide
Copy link
Owner

Perfect! Can we mention this in the documentation for the transport options? Then, we're good to go 💯

@kennethito
Copy link
Contributor Author

Updated with documentation!

lib/xandra.ex Outdated Show resolved Hide resolved
@whatyouhide whatyouhide merged commit 820c34d into whatyouhide:main Apr 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase network buffer size
2 participants