-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Database::iter()
, docs, DB update, deps bump.
#70
Conversation
@gferon we should install a CI step that checks whether the database update is a legitimate update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, although I'd like to have @gferon's view too.
Done! |
Thanks a lot! |
Looks like |
Uh, do we actually need regex 1.10 for the new db to work? Because there's no reason to bump it in EDIT: same with either. And I don't recall why sure why |
Nevermind, that's because it's still on |
Head branch was pushed to by a user without write access
I downgraded the |
Thanks a lot! Merged. I'll publish a new release now. EDIT: here it is - https://crates.io/crates/phonenumber/0.3.5+8.13.36 |
I mainly needed to iterate the DB contents to generate a list of countries/prefixes for a UI where the user enters a phone number. So I added
Database::iter()
.While at it, I also:
doc
-related warnings.8.13.35
.Cargo.toml
:0.3.5+8.13.35
.