Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Database::iter(), docs, DB update, deps bump. #70

Merged
merged 10 commits into from
May 13, 2024

Conversation

virtualritz
Copy link
Contributor

I mainly needed to iterate the DB contents to generate a list of countries/prefixes for a UI where the user enters a phone number. So I added Database::iter().

While at it, I also:

  • Fixed all doc-related warnings.
  • Updated the database to 8.13.35.
  • In Cargo.toml:
    • Bumped all deps .
    • Bumped the crate version to 0.3.5+8.13.35.

@rubdos rubdos requested a review from gferon April 23, 2024 07:40
@rubdos
Copy link
Member

rubdos commented Apr 23, 2024

@gferon we should install a CI step that checks whether the database update is a legitimate update.

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, although I'd like to have @gferon's view too.

src/metadata/database.rs Outdated Show resolved Hide resolved
@gferon
Copy link
Contributor

gferon commented May 7, 2024

we should install a CI step that checks whether the database update is a legitimate update.

Done!

Cargo.toml Outdated Show resolved Hide resolved
@gferon gferon enabled auto-merge May 7, 2024 07:36
@gferon
Copy link
Contributor

gferon commented May 7, 2024

Thanks a lot!

@gferon
Copy link
Contributor

gferon commented May 7, 2024

Looks like regex needs a more recent version of Rust. @rubdos how about bumping our MSRV to 1.65?

@rubdos
Copy link
Member

rubdos commented May 7, 2024

Looks like regex needs a more recent version of Rust. @rubdos how about bumping our MSRV to 1.65?

Uh, do we actually need regex 1.10 for the new db to work? Because there's no reason to bump it in Cargo.toml if we don't.

EDIT: same with either. And I don't recall why sure why strum has this range for a version.

@rubdos
Copy link
Member

rubdos commented May 7, 2024

And I don't recall why sure why strum has this range for a version.

Nevermind, that's because it's still on 0.x :-)

auto-merge was automatically disabled May 13, 2024 13:04

Head branch was pushed to by a user without write access

@virtualritz
Copy link
Contributor Author

I downgraded the regex crate and also bumped the DB to .36.

@gferon gferon enabled auto-merge May 13, 2024 13:09
@gferon gferon merged commit 728ee56 into whisperfish:main May 13, 2024
7 checks passed
@gferon
Copy link
Contributor

gferon commented May 13, 2024

Thanks a lot! Merged. I'll publish a new release now.

EDIT: here it is - https://crates.io/crates/phonenumber/0.3.5+8.13.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants