Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dart-sass as sass compiler #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use dart-sass as sass compiler #43

wants to merge 5 commits into from
+4,972 −2,104

Commits on Nov 29, 2019

  1. Use dart-sass as sass compiler 

    dart-sass is the bleeding edge sass compiler and will always be the first to support new features. Since we want to stay update to date with exciting new sass features this is a natural move.
    @renatodeleao
    renatodeleao committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    f10f1da View commit details
    Browse the repository at this point in the history

  2. update .editorconfig

    @renatodeleao
    renatodeleao committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    f00dcf4 View commit details
    Browse the repository at this point in the history

  3. Add dart sass as sass engine for testing 

    required to add a jest config variable to package.json to overcome this issue
oddbird/true#156
    @renatodeleao
    renatodeleao committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    07623d2 View commit details
    Browse the repository at this point in the history

  4. Fix pow function in order to fix luminance test 

    lumninance uses float exponents which our current pow implmentation doens't support. Replaced with a powerfull math pow function provide by Tobias Bengfort.

Write some more assertions specifient all variations of input values that a pow function can have.
    @renatodeleao
    renatodeleao committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    7695443 View commit details
    Browse the repository at this point in the history

  5. Invalid whitespace chartacter on u-pull utiltiy

    @renatodeleao
    renatodeleao committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    bfb8e0a View commit details
    Browse the repository at this point in the history