Allow merge router, controller and action configuration #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widmogrod
reviewed
Jun 6, 2018
| public function canMergeActionAndRouterConfig() | ||
| { | ||
| return $this->mergeActionAndRouterConfig; | ||
| } |
There was a problem hiding this comment.
To prevent potential regression in future releases, I will ask you to test that default configuration is set to false.
Test class for this file can be found here:
https://github.com/widmogrod/zf2-assetic-module/blob/master/tests/AsseticBundleTest/Configuration.php
| $config = $this->getRouterConfig(); | ||
| $mergeConfigs = $this->configuration->canMergeActionAndRouterConfig(); | ||
| if ($mergeConfigs) { | ||
| $config = array_merge($routerConfig, $config); |
There was a problem hiding this comment.
How would you verify that merging returns the expected result?
There was a problem hiding this comment.
I use this in my project on production and all works as expected.
If you about tests, OK, I'll add some.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #182