Code

Buchungsregeln#1161

Code

Merged

hansmorb merged 195 commits intomasterwielebenwir/commonsbooking:masterfrom feature/issue-697-2wielebenwir/commonsbooking:feature/issue-697-2Copy head branch name to clipboardFeb 22, 2024

+3,228-97

Commits

Commits on Dec 27, 2022

• added comments & type annotations

  hansmorb

  committed
  9b81ce5

  Copy full SHA for 9b81ce5

• added support for terms in optionsArray

  hansmorb

  committed
  bfd81f3

  Copy full SHA for bfd81f3

• added renderingErrors during booking process to frontend

  hansmorb

  committed
  b333800

  Copy full SHA for b333800

• added bookingRules classes with test rules

  hansmorb

  committed
  01b61a1

  Copy full SHA for 01b61a1

• added bookingRule options to frontend

  hansmorb

  committed
  970a6e9

  Copy full SHA for 970a6e9

Commits on Dec 28, 2022

• moved booking form request to run after taxonomy registration

  hansmorb

  committed
  ba0e127

  Copy full SHA for ba0e127

• bookingRule: fixes settings validation

  hansmorb

  committed
  6496c73

  Copy full SHA for 6496c73

• added support for user_id

  hansmorb

  committed
  19f5b47

  Copy full SHA for 19f5b47

• bookingRules: now support roles & terms

  hansmorb

  committed
  adb6b4b

  Copy full SHA for adb6b4b

• bookingRule: added on save validation

  hansmorb

  committed
  b99f347

  Copy full SHA for b99f347

• bookingRule: fixed translations

  hansmorb

  committed
  58e5923

  Copy full SHA for 58e5923

• bookingRule: made options translatable

  hansmorb

  committed
  2fcbfc5

  Copy full SHA for 2fcbfc5

• can now define postStatus of bookings to get for user

  hansmorb

  committed
  25fa92b

  Copy full SHA for 25fa92b

• bookingRule: fix edge cases

  hansmorb

  committed
  ba11aef

  Copy full SHA for ba11aef

• styling and documentation

  hansmorb

  committed
  32b61db

  Copy full SHA for 32b61db

• ran grunt

  hansmorb

  committed
  ea83d73

  Copy full SHA for ea83d73

Commits on Dec 29, 2022

• added check booking for privileged users

  hansmorb

  committed
  ecb02bc

  Copy full SHA for ecb02bc

• bookingRule: fixed display & restructured

  hansmorb

  committed
  4d6c38c

  Copy full SHA for 4d6c38c

Commits on Dec 30, 2022

• bookingRule: added unit tests

  hansmorb

  committed
  d245659

  Copy full SHA for d245659

• added import

  hansmorb

  committed
  f93841f

  Copy full SHA for f93841f

Commits on Jan 9, 2023

• function for retrieving adjacent bookings for Booking

  hansmorb

  committed
  e2d0556

  Copy full SHA for e2d0556

• timeframe: getter for max-days

  hansmorb

  committed
  64a818d

  Copy full SHA for 64a818d

• BookingRule: new rule against chain-booking

  hansmorb

  committed
  654bcdf

  Copy full SHA for 654bcdf

• recompiled js

  hansmorb

  committed
  53b7690

  Copy full SHA for 53b7690

• removed comment

  hansmorb

  authored
  f4ce4e8

  Copy full SHA for f4ce4e8

Commits on Jan 11, 2023

• BookingRule: fixed error in parameter validation

  hansmorb

  committed
  de318e4

  Copy full SHA for de318e4

• Merge remote-tracking branch 'origin/feature/issue-697-2' into feature/issue-697-2

  hansmorb

  committed
  032d5ba

  Copy full SHA for 032d5ba

• trying to fix unit tests - again

  hansmorb

  committed
  48be15e

  Copy full SHA for 48be15e

• booking test: added normal user for booking validation

  hansmorb

  committed
  4cfa6ab

  Copy full SHA for 4cfa6ab

• unit tests: fix again

  hansmorb

  committed
  494439f

  Copy full SHA for 494439f

Commits on Jan 14, 2023

• fixed logic error in privilege check

  hansmorb

  committed
  0b29bc9

  Copy full SHA for 0b29bc9

• fixed BookingRuleTest

  hansmorb

  committed
  de10dad

  Copy full SHA for de10dad

• removed typehints

  hansmorb

  committed
  d21b190

  Copy full SHA for d21b190

• BookingRule: implemented maxBookingDays

  hansmorb

  committed
  5548a89

  Copy full SHA for 5548a89

Commits on Jan 15, 2023

• redid bookingrule tests

  hansmorb

  committed
  e3c929a

  Copy full SHA for e3c929a

• fixed unauthorized booking of denied bookings

  hansmorb

  committed
  23814bc

  Copy full SHA for 23814bc

Commits on Jan 23, 2023

• fixed exception not caught to delete booking after failing

  hansmorb

  committed
  b937afb

  Copy full SHA for b937afb

Commits on Feb 1, 2023

• reworked exception handling for booking form

  hansmorb

  committed
  bff9a7e

  Copy full SHA for bff9a7e

• Merge branch 'master' into feature/issue-697-2

  Show description for 5ffa5ff
  hansmorb

  committed
  5ffa5ff

  Copy full SHA for 5ffa5ff

• booking model: added ability to test for applicable terms

  hansmorb

  committed
  5418dd9

  Copy full SHA for 5418dd9

• booking rule: flipped logic to make less ambiguous

  hansmorb

  committed
  2cb1171

  Copy full SHA for 2cb1171

• booking rule: moved lambdas to separate functions

  hansmorb

  committed
  a6a4668

  Copy full SHA for a6a4668

• added unit tests for new functions

  hansmorb

  committed
  b28daec

  Copy full SHA for b28daec

• removed union types again (PHP 8 feature)

  hansmorb

  committed
  297a07a

  Copy full SHA for 297a07a

Commits on Feb 2, 2023

• clarified exception handling

  hansmorb

  committed
  efe7a5d

  Copy full SHA for efe7a5d

• added list of conflicting bookings to user display

  hansmorb

  committed
  b67f7dc

  Copy full SHA for b67f7dc

Commits on Feb 26, 2023

• BookingRule: restructured class

  hansmorb

  committed
  8f137c4

  Copy full SHA for 8f137c4

• BookingRule: added ability to only apply BookingRule to specific role

  hansmorb

  committed
  cc72aa7

  Copy full SHA for cc72aa7

Commits on Mar 8, 2023

• refactored functions

  hansmorb

  committed
  041db9b

  Copy full SHA for 041db9b

• added additional rule functions

  hansmorb

  committed
  04f053e

  Copy full SHA for 04f053e

• added tests for rule functions

  hansmorb

  committed
  ee1e65a

  Copy full SHA for ee1e65a

• add new maxBookingPerWeek to frontend

  hansmorb

  committed
  703330b

  Copy full SHA for 703330b

• switched logic around, you can now select roles that the user will be excluded from

  hansmorb

  committed
  93c2bc0

  Copy full SHA for 93c2bc0

• reverted change in wrong place, made change in right one

  hansmorb

  committed
  5548988

  Copy full SHA for 5548988

Commits on Mar 10, 2023

• BookingRule: added select as param functionality

  hansmorb

  committed
  f55beea

  Copy full SHA for f55beea

Commits on Mar 11, 2023

• changed ID in OptionsArray to select

  hansmorb

  committed
  5447694

  Copy full SHA for 5447694

Commits on Apr 15, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 319f910
  hansmorb

  committed
  319f910

  Copy full SHA for 319f910

• added ability to fetch JSON object for BookingRuleApplied

  hansmorb

  committed
  51976a3

  Copy full SHA for 51976a3

• set rule from JSON object

  hansmorb

  committed
  3b0b3ff

  Copy full SHA for 3b0b3ff

• ran grunt

  hansmorb

  committed
  57c0667

  Copy full SHA for 57c0667

Commits on Apr 17, 2023

• additional value safety

  hansmorb

  committed
  a13f42c

  Copy full SHA for a13f42c

Commits on Apr 19, 2023

• WIP

  hansmorb

  committed
  e196b22

  Copy full SHA for e196b22

Commits on Apr 20, 2023

• fix booking per week

  hansmorb

  committed
  c5a9663

  Copy full SHA for c5a9663

• extracted function

  hansmorb

  committed
  f21cd30

  Copy full SHA for f21cd30

• moved each unit test to separate function

  hansmorb

  committed
  f66489c

  Copy full SHA for f66489c

• fix getting of month range

  hansmorb

  committed
  d82326b

  Copy full SHA for d82326b

• added frontend selector

  hansmorb

  committed
  6bdfef9

  Copy full SHA for 6bdfef9

• removed debug rule

  hansmorb

  committed
  22470f2

  Copy full SHA for 22470f2

• better test coverage

  hansmorb

  committed
  45b06d4

  Copy full SHA for 45b06d4

Commits on May 16, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for a92bb1c
  hansmorb

  committed
  a92bb1c

  Copy full SHA for a92bb1c

• re-added old function to get DT object

  hansmorb

  committed
  f319761

  Copy full SHA for f319761

Commits on May 24, 2023

• fixed february tests

  hansmorb

  committed
  ade15c0

  Copy full SHA for ade15c0

• added title for parameters

  hansmorb

  committed
  e028202

  Copy full SHA for e028202

Commits on Jun 1, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 58d3013
  hansmorb

  committed
  58d3013

  Copy full SHA for 58d3013

Commits on Jun 2, 2023

• removed doubled function and fixed tests

  hansmorb

  committed
  0598169

  Copy full SHA for 0598169

• fixed tests executed twice due to inheritance

  hansmorb

  committed
  04bde0f

  Copy full SHA for 04bde0f

• test pipeline wo pullrequest

  datengraben

  authored
  059e191

  Copy full SHA for 059e191

Commits on Jun 3, 2023

• wip fix order problem in array equals test

  datengraben

  authored
  8438903

  Copy full SHA for 8438903

• update docblock

  datengraben

  authored
  0eee203

  Copy full SHA for 0eee203

• Set ascending order

  datengraben

  authored
  521b938

  Copy full SHA for 521b938

Commits on Jul 5, 2023

• added different behaviour for getLength and basic tests

  hansmorb

  committed
  d3513bb

  Copy full SHA for d3513bb

• Merge branch 'master' into feature/issue-697-2

  Show description for be89406
  hansmorb

  committed
  be89406

  Copy full SHA for be89406

• changed behaviour of getLength: one hour tolerance until a day counts as started

  hansmorb

  committed
  2cba4be

  Copy full SHA for 2cba4be

• more specific tests for getLength

  hansmorb

  committed
  f412480

  Copy full SHA for f412480

Commits on Jul 6, 2023

• BookingRule: implemented option to count cancelled bookings during period

  hansmorb

  committed
  79c5939

  Copy full SHA for 79c5939

• added tests for counting of cancelled bookings

  hansmorb

  committed
  dea6907

  Copy full SHA for dea6907

• additional type safety

  hansmorb

  committed
  a2e96ee

  Copy full SHA for a2e96ee

Commits on Jul 9, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for ba272d7
  hansmorb

  committed
  ba272d7

  Copy full SHA for ba272d7

• fixed issue from changed constant

  hansmorb

  committed
  556d487

  Copy full SHA for 556d487

• fixed unit tests (stupid mistake already fixed in PR #1173)

  hansmorb

  committed
  49375d0

  Copy full SHA for 49375d0

• fixed slightly broken chain-booking detection

  hansmorb

  committed
  c4d71b6

  Copy full SHA for c4d71b6

• re-factoring & type safety

  hansmorb

  committed
  367d7d3

  Copy full SHA for 367d7d3

• fixed js

  hansmorb

  committed
  b849bfa

  Copy full SHA for b849bfa

• added catching for cases where booking is not yet created

  hansmorb

  committed
  346e1e6

  Copy full SHA for 346e1e6

• documentation & string fixes

  hansmorb

  committed
  45de5f3

  Copy full SHA for 45de5f3

• added support to have closure function as error message (-> more detailed error messages)

  hansmorb

  committed
  be63f4b

  Copy full SHA for be63f4b

• also add unit tests for weird edge cases

  hansmorb

  committed
  f8d3426

  Copy full SHA for f8d3426

• add test for terms apply

  hansmorb

  committed
  1fd2eee

  Copy full SHA for 1fd2eee

Commits on Jul 27, 2023

• fixed that bookings cancelled before start date were counted

  hansmorb

  committed
  1a2dce5

  Copy full SHA for 1a2dce5

• Merge branch 'master' into feature/issue-697-2

  Show description for 2421af5
  hansmorb

  committed
  2421af5

  Copy full SHA for 2421af5

• fixes after merge

  hansmorb

  committed
  505752c

  Copy full SHA for 505752c

• fixed double validation after merge

  hansmorb

  committed
  19b930d

  Copy full SHA for 19b930d

• undone unwanted changes

  hansmorb

  committed
  df3f9ad

  Copy full SHA for df3f9ad

• fixed changes after merge

  hansmorb

  committed
  60c167b

  Copy full SHA for 60c167b

• extra unit tests

  hansmorb

  committed
  2b1a678

  Copy full SHA for 2b1a678

• fixed paramtest & docs

  hansmorb

  committed
  51a047c

  Copy full SHA for 51a047c

Commits on Aug 11, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 5f5444d
  hansmorb

  committed
  5f5444d

  Copy full SHA for 5f5444d

• additional tests for term application

  hansmorb

  committed
  028a2a2

  Copy full SHA for 028a2a2

Commits on Aug 16, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for c5b77ef
  hansmorb

  committed
  c5b77ef

  Copy full SHA for c5b77ef

• use correct parameters for maxBookingDays

  hansmorb

  committed
  28e7214

  Copy full SHA for 28e7214

• style fixes

  hansmorb

  committed
  df42384

  Copy full SHA for df42384

• added link to documentation

  hansmorb

  committed
  059fe53

  Copy full SHA for 059fe53

• fixed type issue

  hansmorb

  committed
  953687d

  Copy full SHA for 953687d

• fixed issue with invalid rules breaking backend settings

  hansmorb

  committed
  3c575b2

  Copy full SHA for 3c575b2

Commits on Aug 17, 2023

• removed not working type definition

  hansmorb

  committed
  e68ac76

  Copy full SHA for e68ac76

• made better rule title

  hansmorb

  committed
  77e8d9d

  Copy full SHA for 77e8d9d

• made rule selector more readable

  hansmorb

  committed
  7db53b2

  Copy full SHA for 7db53b2

• Merge branch 'master' into feature/issue-697-2

  Show description for c23a934
  hansmorb

  committed
  c23a934

  Copy full SHA for c23a934

• grunt after merge

  hansmorb

  committed
  3b36530

  Copy full SHA for 3b36530

• refactored excluded user roles

  hansmorb

  committed
  7b73494

  Copy full SHA for 7b73494

• added tests for excluded user roles

  hansmorb

  committed
  50b4a22

  Copy full SHA for 50b4a22

• added tests for filterTermsApply

  hansmorb

  committed
  6ca400b

  Copy full SHA for 6ca400b

• better name for function

  hansmorb

  committed
  6afc029

  Copy full SHA for 6afc029

• more unit tests

  hansmorb

  committed
  a301ecd

  Copy full SHA for a301ecd

• revert unnecessary changes

  hansmorb

  committed
  3ad2a7a

  Copy full SHA for 3ad2a7a

Commits on Sep 7, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for a9f1052
  hansmorb

  committed
  a9f1052

  Copy full SHA for a9f1052

• grunt after merge

  hansmorb

  committed
  24981ae

  Copy full SHA for 24981ae

Commits on Sep 25, 2023

• added cancellation-time to frontend cancel request

  hansmorb

  committed
  f2c2462

  Copy full SHA for f2c2462

• refactored unit tests

  hansmorb

  committed
  f3f48f4

  Copy full SHA for f3f48f4

Commits on Sep 26, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for cb26270
  hansmorb

  committed
  cb26270

  Copy full SHA for cb26270

• re-added tests to different folder

  hansmorb

  committed
  637c661

  Copy full SHA for 637c661

• minor re-factoring

  hansmorb

  committed
  27830b2

  Copy full SHA for 27830b2

Commits on Sep 28, 2023

• Merge branch 'master' into feature/issue-697-2

  hansmorb

  committed
  910cbd2

  Copy full SHA for 910cbd2

• exempt priviledged users from advance booking days setting

  hansmorb

  committed
  a2cb408

  Copy full SHA for a2cb408

• added test for role type ID

  hansmorb

  committed
  26eb725

  Copy full SHA for 26eb725

• more finely granulated control over custom caches for user roles

  hansmorb

  committed
  2a67632

  Copy full SHA for 2a67632

Commits on Oct 15, 2023

• Merge branch 'master' into feature/issue-697-2

  hansmorb

  authored
  6dd41fe

  Copy full SHA for 6dd41fe

Commits on Oct 22, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 19bcf4a
  hansmorb

  committed
  19bcf4a

  Copy full SHA for 19bcf4a

Commits on Oct 24, 2023

• added extra test for isUserPrivileged

  hansmorb

  committed
  0842560

  Copy full SHA for 0842560

• fixed broken unit tests

  hansmorb

  committed
  80138f9

  Copy full SHA for 80138f9

Commits on Oct 25, 2023

• added class annotations

  hansmorb

  committed
  903eb41

  Copy full SHA for 903eb41

• fixed inconsistencies /w weekday reset

  hansmorb

  committed
  42cab83

  Copy full SHA for 42cab83

Commits on Nov 2, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for ab45b3d
  hansmorb

  committed
  ab45b3d

  Copy full SHA for ab45b3d

• grunt after merge

  hansmorb

  committed
  d84262a

  Copy full SHA for d84262a

• remove cosmetic changes that pollute change overview

  hansmorb

  committed
  29fc094

  Copy full SHA for 29fc094

Commits on Nov 7, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for ea73206
  hansmorb

  committed
  ea73206

  Copy full SHA for ea73206

Commits on Nov 8, 2023

• fix test

  hansmorb

  committed
  2df3d3c

  Copy full SHA for 2df3d3c

Commits on Nov 16, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 9245ad1
  hansmorb

  committed
  9245ad1

  Copy full SHA for 9245ad1

Commits on Nov 21, 2023

• Merge branch 'master' into feature/issue-697-2

  Show description for 79f269d
  hansmorb

  committed
  79f269d

  Copy full SHA for 79f269d

• grunt after merge

  hansmorb

  committed
  01b7e77

  Copy full SHA for 01b7e77

• remove #1418 (moved to separate PR)

  hansmorb

  committed
  2ddceff

  Copy full SHA for 2ddceff

• removed function from #1418

  hansmorb

  committed
  45da0ca

  Copy full SHA for 45da0ca

Commits on Dec 13, 2023

• added own hook for privileged roles

  hansmorb

  committed
  2e71dfb

  Copy full SHA for 2e71dfb

• added direct links to affected bookings

  hansmorb

  committed
  82aa2aa

  Copy full SHA for 82aa2aa

• fix error message containing cancelled bookings

  hansmorb

  committed
  515b126

  Copy full SHA for 515b126

• added extra checks

  hansmorb

  committed
  96c0f7a

  Copy full SHA for 96c0f7a

Commits on Dec 16, 2023

• Merge branch 'master' into feature/issue-697-2

  hansmorb

  authored
  a9914a5

  Copy full SHA for a9914a5

Commits on Jan 11, 2024

• use existing translations wherever possible

  hansmorb

  committed
  096a9bb

  Copy full SHA for 096a9bb

Commits on Jan 17, 2024

• added better error handling for unset rules

  hansmorb

  committed
  5c4feda

  Copy full SHA for 5c4feda

• Merge branch 'master' into feature/issue-697-2

  hansmorb

  authored
  d0dcd79

  Copy full SHA for d0dcd79

• bookings will now save amount of overbooked days

  hansmorb

  committed
  628c578

  Copy full SHA for 628c578

• Merge remote-tracking branch 'origin/feature/issue-697-2' into feature/issue-697-2

  hansmorb

  committed
  1ac7d5c

  Copy full SHA for 1ac7d5c

Commits on Jan 18, 2024

• overbooked days now set according to location settings

  hansmorb

  committed
  bed5460

  Copy full SHA for bed5460

• make booking length respect overbooked days

  hansmorb

  committed
  426f2a9

  Copy full SHA for 426f2a9

• removed accidental double-rendering of error message (wasn't visible because transient is deleted after first time)

  hansmorb

  committed
  27fdb32

  Copy full SHA for 27fdb32

Commits on Jan 19, 2024

• introduced new rule, refactoring & renaming

  hansmorb

  committed
  c747181

  Copy full SHA for c747181

• pre-pend error message to post instead of append

  hansmorb

  committed
  6ff8df0

  Copy full SHA for 6ff8df0

Commits on Jan 20, 2024

• added error handling for unset select parameter

  hansmorb

  committed
  ab4399c

  Copy full SHA for ab4399c

• fixed backend crashing when deleting booking rule

  hansmorb

  committed
  51342ac

  Copy full SHA for 51342ac

Commits on Jan 21, 2024

• fix select param checking - again

  hansmorb

  committed
  a879e88

  Copy full SHA for a879e88

• fixed issues with select argument not properly saving

  hansmorb

  committed
  8adfa56

  Copy full SHA for 8adfa56

• added error for non-numeric parameter inputs

  hansmorb

  committed
  a7719f6

  Copy full SHA for a7719f6

Commits on Feb 8, 2024

• Merge branch 'master' into feature/issue-697-2

  Show description for 58eae90
  hansmorb

  committed
  58eae90

  Copy full SHA for 58eae90

• remove doubled implementation

  hansmorb

  committed
  bc83728

  Copy full SHA for bc83728

• compile minified js

  hansmorb

  committed
  9247417

  Copy full SHA for 9247417

Commits on Feb 17, 2024

• Improve english wording

  datengraben

  authored
  dcfd29e

  Copy full SHA for dcfd29e

• bookingrule: indent js

  datengraben

  committed
  6fc4a0a

  Copy full SHA for 6fc4a0a

• BookingRule: document usage and types more clearly

  datengraben

  committed
  4d5e179

  Copy full SHA for 4d5e179

• spelling typo in comment

  datengraben

  committed
  66b4b01

  Copy full SHA for 66b4b01

• Merge branch 'master' into feature/issue-697-2

  datengraben

  authored
  13fb11a

  Copy full SHA for 13fb11a

Commits on Feb 18, 2024

• refactored adjacent method

  hansmorb

  committed
  45f93ee

  Copy full SHA for 45f93ee

• Merge remote-tracking branch 'origin/feature/issue-697-2' into feature/issue-697-2

  hansmorb

  committed
  32bd7e3

  Copy full SHA for 32bd7e3

• litepicker.js: add comment and indent code

  datengraben

  committed
  90e331e

  Copy full SHA for 90e331e

• fix documentation

  hansmorb

  committed
  d2dceec

  Copy full SHA for d2dceec

• renamed length method

  hansmorb

  committed
  a5a0c2c

  Copy full SHA for a5a0c2c

• fixed redundant null-safety

  hansmorb

  committed
  2df2d9a

  Copy full SHA for 2df2d9a

• pick roleID instead of translation for excluding admins from user roles

  hansmorb

  committed
  be8cb39

  Copy full SHA for be8cb39

• Merge remote-tracking branch 'origin/feature/issue-697-2' into feature/issue-697-2

  hansmorb

  committed
  458a130

  Copy full SHA for 458a130

• fixed method access for getForCurrentUser

  hansmorb

  committed
  51af284

  Copy full SHA for 51af284

• fixed documentation

  hansmorb

  committed
  ece66b7

  Copy full SHA for ece66b7

• fixed documentation

  hansmorb

  committed
  37ece2f

  Copy full SHA for 37ece2f

• refactored userHasRoles

  hansmorb

  committed
  de1f810

  Copy full SHA for de1f810

Commits on Feb 21, 2024

• Booking: refactor duration names

  datengraben

  committed
  8cbc473

  Copy full SHA for 8cbc473

• doc: adds @SInCE annotation to phpdoc

  datengraben

  committed
  0654145

  Copy full SHA for 0654145

• refactors unreachable statement and indent

  datengraben

  committed
  2d66235

  Copy full SHA for 2d66235