Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get ready for mw-message-box deprecation #2014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NovemLinguae
Copy link
Member

fixes #2012

Was unable to use Codex, because Codex is usually only loaded on certain pages by certain extensions that use Codex. There is no guarantee it would be loaded and available on the page [[Wikipedia:Twinkle/Preferences]].

The strategy in this patch is to copy paste the necessary CSS from MediaWiki to Morebits.

fixes wikimedia-gadgets#2012

Was unable to use Codex, because Codex is usually only loaded on certain pages by certain extensions that use Codex. There is no guarantee it would be loaded and available on the page [[Wikipedia:Twinkle/Preferences]].

The strategy in this patch is to copy paste the necessary CSS from MediaWiki to Morebits.
@github-actions github-actions bot added Module: morebits The morebits.js library Module: config labels Sep 19, 2024
@jdlrobson
Copy link
Contributor

jdlrobson commented Sep 19, 2024

Was unable to use Codex, because Codex is usually only loaded on certain pages by certain extensions that use Codex.

Codex is opt in so if you are using the markup and you need to add the styles you should add mediawiki.htmlform.codex.styles as well and then you can use them.

Note, on skins which use Codex e.g. Vector 2022 and Minerva Codex so the module should only be needed on skins where it is not, so if you wanted to optimize you could limit where it's loaded.

@NovemLinguae
Copy link
Member Author

Thanks @jdlrobson . So you're saying that one approach to writing this patch would be to do something like mw.loader.using( [ 'mediawiki.htmlform.codex.styles' ], to ensure that Codex is loaded and available on skins such as Vector 2010?

@jdlrobson
Copy link
Contributor

jdlrobson commented Sep 20, 2024

Yes! If you are not ready to change the markup just yet, you can also add mediawiki.legacy.messageBox for now (will be available from next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: config Module: morebits The morebits.js library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: change mw-message-box to something else
2 participants