Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WikiGames: the final result screen #5255

Merged
merged 34 commits into from
Jan 31, 2025
Merged

WikiGames: the final result screen #5255

merged 34 commits into from
Jan 31, 2025

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Jan 24, 2025

@cooltey cooltey added the WIP Work in progress label Jan 24, 2025
cooltey and others added 20 commits January 24, 2025 09:41
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
9ff555d
@cooltey
Change radius
9002490
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
c23235b
@cooltey
Stats view
c07bb92
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
1166d07
@cooltey
Hygiene a bit
76a5024
@cooltey
Add functions for stat cards
0fe3d47
@cooltey
Update recycler view item
9c0363c
@dbrant
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
5ff9713
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
72cca26
@cooltey
Nest it
e3d2f7b
@cooltey
Change coordinateLayout to Framelayout to avoid jumpy view when
02b359a 
scrolling
@cooltey
Add icons
c97afa3
@cooltey
update the logic of showing card colors
11e6e44
@cooltey
Add article share function
8f85295
@cooltey
Some tweak
4987d7c
@cooltey
Update color
0078662
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
2fb32a8
@cooltey
Update card color to non-themed group
b629212
@cooltey
Update design
083205c
@cooltey cooltey added Ready to merge PR passed design signoff and ready to be merged. WIP Work in progress and removed WIP Work in progress Ready to merge PR passed design signoff and ready to be merged. labels Jan 28, 2025
cooltey and others added 6 commits January 30, 2025 08:56
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
2ea0676 
* whichCameFirst_design:
  Bump com.github.skydoves:balloon from 1.6.11 to 1.6.12 (#5272)
  Remove SuggestedEdits survey (#5276)
  - strings for notification (#5277)
  Update strings for wiki game final result screen (#5274)
  Remove unused Contributions Dashboard url (#5275)
@cooltey
Code review comment
88d0d8b
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
20a22e3
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
e0b7a1a 
* whichCameFirst_design:
  Bump androidx.compose:compose-bom from 2025.01.00 to 2025.01.01
@cooltey
!?
b31ca74
@cooltey
Merge branch 'whichCameFirst_design' into wikigame-finalscreen-design
ae03542
@dbrant dbrant merged commit b8582ba into whichCameFirst_design Jan 31, 2025
2 checks passed
@dbrant dbrant deleted the wikigame-finalscreen-design branch January 31, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Williamrai Williamrai Williamrai left review comments

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cooltey @Williamrai @dbrant