Merge pull request #4589 from wikimedia/diff-user-menu-action-change

Diff user menu action change
wikimedia · Aug 3, 2023 · cbeb622 · cbeb622
2 parents 6bb6481 + a7b240f
commit cbeb622
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/WMF Framework/Event Platform/EventPlatformClient.swift b/WMF Framework/Event Platform/EventPlatformClient.swift
@@ -156,7 +156,7 @@ import CocoaLumberjackSwift
         case login = "/analytics/mobile_apps/ios_login_action/1.0.2"
         case navigation = "/analytics/mobile_apps/ios_navigation_events/1.0.0"
         case editAttempt = "/analytics/legacy/editattemptstep/1.4.0"
-        case watchlist = "/analytics/mobile_apps/ios_watchlists/2.0.0"
+        case watchlist = "/analytics/mobile_apps/ios_watchlists/3.0.0"
     }
 
     /**

diff --git a/Wikipedia.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Wikipedia.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -24,7 +24,7 @@
       "location" : "https://github.com/wikimedia/wikipedia-ios-components.git",
       "state" : {
         "branch" : "main",
-        "revision" : "3e484e694759f137f92361d2e83cb3bce7b3b974"
+        "revision" : "6dafa78148de54647565fd04d1c32c8114869ef5"
       }
     },
     {

diff --git a/Wikipedia/Code/WatchlistFunnel.swift b/Wikipedia/Code/WatchlistFunnel.swift
@@ -8,8 +8,8 @@ final class WatchlistFunnel {
     private enum Action: String, Codable {
         case diffOpen = "diff_open"
         case diffUserMenu = "diff_user_menu"
-        case diffUserMenuFrom = "diff_user_menu_from"
-        case diffUserMenuTo = "diff_user_menu_to"
+        case diffUserMenuPrevious = "diff_user_menu_previous"
+        case diffUserMenuDisplay = "diff_user_menu_display"
         case diffUserPage = "diff_user_page"
         case diffUserTalk = "diff_user_talk"
         case diffUserContribution = "diff_user_contribution"
@@ -94,14 +94,14 @@ final class WatchlistFunnel {
         guard let project else {
             return
         }
-        logEvent(action: .diffUserMenuFrom, project: project)
+        logEvent(action: .diffUserMenuPrevious, project: project)
     }
 
     func logDiffTapCompareToEditorName(project: WikimediaProject?) {
         guard let project else {
             return
         }
-        logEvent(action: .diffUserMenuTo, project: project)
+        logEvent(action: .diffUserMenuDisplay, project: project)
     }
 
     func logDiffTapUserPage(project: WikimediaProject?) {

diff --git a/Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings b/Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings