Share GIF #2263
Merged
Share GIF #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sharing an animated gif image from the gallery view, it only shares a still png image https://phabricator.wikimedia.org/T139519
|
Can one of the admins verify this patch? |
|
@tiagomartinho thank you for the PR! Looks good to me + tested on a device :) 👍 It fixes a slightly different bug than the one described in the ticket (the ticket's reproduction steps are to copy & paste the image, here you're fixing sharing a gif). Either way, it's nice to see one of those bugs fixed! |
|
Yes @nambatee! I also fixed the copy bug in the NYTimes library and in the Wikimedia fork but I couldn't understand why the Wikipedia app doesn't inherit the bug fix. I couldn't find any override of UIPasteboard or UIMenuController in the iOS app. |
|
OK to test |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sharing an animated gif image from the gallery view, it only shares a still png image
https://phabricator.wikimedia.org/T139519