Make the back and forward buttons only enabled when the webview can a…

…ctually go back or forward.
wikimedia · Aug 8, 2011 · f29b217 · f29b217
1 parent b7c2819
commit f29b217
Show file tree

Hide file tree

Showing 9 changed files with 4,354 additions and 2,925 deletions.
diff --git a/Classes/RootViewController.h b/Classes/RootViewController.h
@@ -14,7 +14,11 @@
 	Wikipedia_MobileAppDelegate *appDelegate;
 
 	UIWebView *webView;
-	IBOutlet UISearchBar *searchBar;
+	UISearchBar *searchBar;
+	UIToolbar *toolBar;
+	UIBarButtonItem *backButton;
+	UIBarButtonItem *forwardButton;
+
 	NSString *pageTitle;
 	UIView *shade;
 	UITableView *tableView;
@@ -29,7 +33,10 @@
 @property (nonatomic, retain) Wikipedia_MobileAppDelegate *appDelegate;
 
 @property (nonatomic, retain) IBOutlet UIWebView *webView;
-@property (nonatomic, retain) UISearchBar *searchBar;
+@property (nonatomic, retain) IBOutlet UISearchBar *searchBar;
+@property (nonatomic, retain) IBOutlet UIToolbar *toolBar;
+@property (nonatomic, retain) IBOutlet UIBarButtonItem *backButton;
+@property (nonatomic, retain) IBOutlet UIBarButtonItem *forwardButton;
 @property (nonatomic, retain) NSString *pageTitle;
 @property (nonatomic, retain) IBOutlet UIView *shade;
 @property (nonatomic, retain) IBOutlet UITableView *tableView;

diff --git a/Classes/RootViewController.m b/Classes/RootViewController.m
@@ -18,7 +18,7 @@
 
 @implementation RootViewController
 
-@synthesize webView, searchBar, searchResults;
+@synthesize webView, searchBar, searchResults, toolBar, backButton, forwardButton;
 @synthesize appDelegate, pageTitle, shade, tableView;
 
 @synthesize managedObjectContext;
@@ -47,6 +47,9 @@ - (void)viewDidLoad {
 	searchBar.showsScopeBar = NO;
 	searchBar.frame = CGRectMake(0, 0, 320.0f, 44.0f);
 
+        backButton.enabled = NO;
+        forwardButton.enabled = NO;
+
 	[self loadStartPage];
 
 	self.managedObjectContext = appDelegate.managedObjectContext;
@@ -118,7 +121,9 @@ - (void)handleTimer:(NSTimer *)timer
 	}
 }
 
-- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error {
+#pragma mark WebViewDelegate
+
+- (void)webView:(UIWebView *)awebView didFailLoadWithError:(NSError *)error {
 	[timer invalidate];
 	if (error != nil) {
 		NSString *errorString = [NSString stringWithFormat:@"%@", error];
@@ -133,9 +138,12 @@ - (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error {
 		[UIApplication sharedApplication].networkActivityIndicatorVisible = NO; 
 		[HUD hide:YES];
 	}
+
+        self.backButton.enabled = awebView.canGoBack;
+        self.forwardButton.enabled = awebView.canGoForward;
 }
 
-- (void)webViewDidFinishLoad:(UIWebView *)webView {
+- (void)webViewDidFinishLoad:(UIWebView *)awebView {
 	[UIApplication sharedApplication].networkActivityIndicatorVisible = NO; 
 
 	pageTitle = [self.webView stringByEvaluatingJavaScriptFromString:@"document.title"]; 
@@ -151,6 +159,9 @@ - (void)webViewDidFinishLoad:(UIWebView *)webView {
 	if (![pageTitle isEqualToString:@"Wikipedia"] && ![pageTitle isEqualToString:nil]) {
 		[self addRecentPage:pageTitle];
 	}
+
+        self.backButton.enabled = awebView.canGoBack;
+        self.forwardButton.enabled = awebView.canGoForward;
 }
 
 - (void)addRecentPage:(NSString *)pageName {

diff --git a/Classes/WikiViewController.h b/Classes/WikiViewController.h
@@ -16,6 +16,9 @@
 
 	NSString *wikiEntryURL;
 	UIWebView *webView;
+        UIToolbar *toolbar;
+        UIBarButtonItem *backButton;
+        UIBarButtonItem *forwardButton;
 	MapViewController *superView;
 	NSString *pageTitle;
 	MBProgressHUD *HUD;
@@ -27,6 +30,9 @@
 
 @property (nonatomic, retain) NSString *wikiEntryURL;
 @property (nonatomic, retain) NSString *pageTitle;
+@property (nonatomic, retain) IBOutlet UIToolbar *toolbar;
+@property (nonatomic, retain) IBOutlet UIBarButtonItem *backButton;
+@property (nonatomic, retain) IBOutlet UIBarButtonItem *forwardButton;
 @property (nonatomic, retain) IBOutlet UIWebView *webView;
 @property (nonatomic, retain) MapViewController *superView;
 

diff --git a/Classes/WikiViewController.m b/Classes/WikiViewController.m
@@ -13,7 +13,7 @@
 
 @implementation WikiViewController
 
-@synthesize appDelegate, wikiEntryURL, webView, superView;
+@synthesize appDelegate, wikiEntryURL, webView, superView, toolbar, backButton, forwardButton;
 @synthesize pageTitle;
 @synthesize managedObjectContext;
 
@@ -39,9 +39,11 @@ - (void)viewDidLoad {
 	self.managedObjectContext = appDelegate.managedObjectContext;
 
 	[webView setBackgroundColor:[UIColor colorWithPatternImage:[UIImage imageWithContentsOfFile:@"UITexture2.png"]]];
+        backButton.enabled = NO;
+        forwardButton.enabled = NO;
 
 	NSMutableURLRequest *URLrequest = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:wikiEntryURL]];
-	[URLrequest setValue:@"Wikipedia Mobile/2.0" forHTTPHeaderField:@"User_Agent"];
+	[URLrequest setValue:@"Wikipedia Mobile/2.0" forHTTPHeaderField:@"User-Agent"];
 
 	[webView loadRequest:URLrequest];
 }
@@ -52,17 +54,20 @@ - (void)webViewDidStartLoad:(UIWebView *)webView {
 	[self showLoadingHUD];
 }
 
-- (void)webView:(UIWebView *)webView didFailLoadWithError:(NSError *)error {
+- (void)webView:(UIWebView *)awebView didFailLoadWithError:(NSError *)error {
 	if (error != nil) {
 		NSString *errorString = [NSString stringWithFormat:@"%@", error];
 		NSLog(@"%@", errorString);
 
 		[UIApplication sharedApplication].networkActivityIndicatorVisible = NO; 
 		[HUD hide:YES];
 	}
+
+        self.backButton.enabled = awebView.canGoBack;
+        self.forwardButton.enabled = awebView.canGoForward;
 }
 
-- (void)webViewDidFinishLoad:(UIWebView *)webView {
+- (void)webViewDidFinishLoad:(UIWebView *)awebView {
 	[UIApplication sharedApplication].networkActivityIndicatorVisible = NO;
 
 	pageTitle = [self.webView stringByEvaluatingJavaScriptFromString:@"document.title"]; 
@@ -72,6 +77,9 @@ - (void)webViewDidFinishLoad:(UIWebView *)webView {
 	if (![pageTitle isEqualToString:@"Wikipedia"] && ![pageTitle isEqualToString:nil]) {
 		[self addRecentPage:pageTitle];
 	}
+
+        self.backButton.enabled = awebView.canGoBack;
+        self.forwardButton.enabled = awebView.canGoForward;
 }