Switched archetypes to JUnit5 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
approved these changes
Nov 27, 2023
jmesnil
approved these changes
Nov 28, 2023
|
Thank you @WolfgangHG! This is a big improvement IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to use JUnit5 in the archetypes where possible. What do you think?
WildFly BOM still brings JUnit4, so i have to define a JUnit5 version. And the sample at https://github.com/junit-team/junit5-samples/blob/r5.10.1/junit5-jupiter-starter-maven/pom.xml defines a "junit-bom" in "dependencyManagement", so I followed this sample, too. Don't know whether this is required, as some of the components are probably not usable in the arquillian environment.
The subsystem archetype has to stay with JUnit4, as "org.wildfly.core:wildfly-subsystem-test-framework" (https://github.com/wildfly/wildfly-core/tree/main/subsystem-test/framework) only supports JUnit4 and thus the subsystem tests would fail with JUnit5.