energy #350
Merged
energy #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shing-toolkit into hackthon/yunfan/energy
… building due to autodiff not included
mtao
reviewed
Aug 28, 2023
Closed
mtao
reviewed
Aug 30, 2023
src/wmtk/energy/ValenceEnergy.cpp
Outdated
| // assume tuple is not a boundary edge | ||
| const Tuple current_v = tuple; | ||
| const Tuple other_v = m_mesh.switch_vertex(tuple); | ||
| long val0 = static_cast<long>(SimplicialComplex::vertex_one_ring(mesh(), current_v).size()); |
There was a problem hiding this comment.
this valence definition is very specific to collapse. The ValenceEnergy should just return the valence - this calculation for predicting the before/after only makes sense as an Invariant
…shing-toolkit into hackthon/yunfan/energy
…n/yunfan/energy
…ng/wildmeshing-toolkit into hackthon/yunfan/energy
… Mesh Valence function
…y-what-simplex-they-operate-on
…lidity of PerSimplexFunction at construction time
…lex-they-operate-on' of https://github.com/wildmeshing/wildmeshing-toolkit into 456-improve-semantics-of-functions-to-clarify-what-simplex-they-operate-on
…ctions-to-clarify-what-simplex-they-operate-on 456 improve semantics of functions to clarify what simplex they operate on
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 85.81% 83.40% -2.42%
==========================================
Files 187 213 +26
Lines 5401 5948 +547
==========================================
+ Hits 4635 4961 +326
- Misses 766 987 +221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.