Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

472 edgemesh trimesh multimesh tuple map updates after operations #482

Merged
merged 38 commits into from
Nov 17, 2023
Merged

472 edgemesh trimesh multimesh tuple map updates after operations #482

merged 38 commits into from
Nov 17, 2023

Conversation

zlyfunction
Copy link
Collaborator

  1. Implemented the functor for updating the map between the edge mesh and the triangle mesh:
    • Registered the map for the new edges created by the split operation.
    • Updated the hash in the map for those edges that potentially underwent hash changes.
  2. Fixed bugs in the multi-mesh hash map functions.

@zlyfunction
init
5ac46ca
@zlyfunction
fix segfaults in tests
112ab9d
@zlyfunction
add tuple_from_global_ids in EdgeMesh
7488421
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
7cfa37b 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
Merge branch '468-optimize-the-find_local_switch_sequence-function' of …
0c54e57 
…https://github.com/wildmeshing/wildmeshing-toolkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
Merge branch '434-edgemesh-to-trimesh-multimesh-register' of https://…
8a4c1d7 
…github.com/wildmeshing/wildmeshing-toolkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
f1b3707 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
update the new edges created by edge split
a5e30c8
@zlyfunction
fix many bugs
6691476
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
dd65d7a 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
add/delete comments
0ee4984
@zlyfunction zlyfunction self-assigned this Oct 30, 2023
@zlyfunction zlyfunction linked an issue Oct 30, 2023 that may be closed by this pull request
EdgeMesh-TriMesh multimesh tuple_map updates after operations #472
Closed
4 tasks
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b82fba0) 85.76% compared to head (818490b) 86.29%.

Files Patch % Lines
src/wmtk/operations/tri_mesh/EdgeCollapse.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   85.76%   86.29%   +0.52%     
==========================================
  Files         210      208       -2     
  Lines        6226     6289      +63     
==========================================
+ Hits         5340     5427      +87     
+ Misses        886      862      -24
Flag Coverage Δ
wildmeshing 86.29% <98.30%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zlyfunction zlyfunction marked this pull request as draft October 30, 2023 16:17
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
5d64fec 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
0e68e78 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
fix bug in attribute copy
e164182
@zlyfunction
fix bug in ear-replacing case in collapse edge
6e8e82b
@zlyfunction
add back test
3cfc776
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
a2250f4 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
81726bb 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
fix compile
140ca1d
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
d5d7abb 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
test MultiMeshLinkConditionInvariant in tri_tri case
f20b8e0
@zlyfunction
add link cond for edge mesh
8feaade
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
e2cdd72 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
modify multimesh link cond test
3c84b0a
@zlyfunction
update
677ee56
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
246233f 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
add files
fb13fd1
@zlyfunction
add comments
0b87441
@zlyfunction
udpate
b1c4905
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
95af279 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
update
8518f11
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
86bf9ae 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
add functors
c9e3c24
@zlyfunction
fix bug
529ac09
@zlyfunction
fix bug
d1c06bd
@zlyfunction
Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…
2954b23 
…lkit into 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations
@zlyfunction
clean up
97260d4
@zlyfunction
add the test that will fail
818490b
@zlyfunction zlyfunction requested review from mtao and daniel-zint and removed request for mtao November 16, 2023 00:31
@zlyfunction zlyfunction marked this pull request as ready for review November 16, 2023 00:33
@zlyfunction zlyfunction requested a review from JcDai November 16, 2023 03:38
mtao
mtao approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@mtao mtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we said we would accept bascially as is and then fix after right?
feel free to merge

@zlyfunction zlyfunction merged commit 2c69fc9 into main Nov 17, 2023
9 checks passed
@zlyfunction zlyfunction deleted the 472-edgemesh-trimesh-multimesh-tuple_map-updates-after-operations branch November 17, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtao mtao mtao approved these changes

@daniel-zint daniel-zint Awaiting requested review from daniel-zint

@JcDai JcDai Awaiting requested review from JcDai

Assignees

@zlyfunction zlyfunction

Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EdgeMesh-TriMesh multimesh tuple_map updates after operations
2 participants
@zlyfunction @mtao