Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tool to convert wmtk mesh types #832

Merged
merged 33 commits into from
Nov 16, 2024

Conversation

mtao
Copy link
Collaborator

@mtao mtao commented Oct 29, 2024

We currently support 2-3 mesh formats within the toolkit (vtu / hdf5 / msh) and it would be useful to be able to directly create/manipulate meshes using them. This is particularly annoying because hdf5 supports multimesh configurations while others do not - For building examples that use multimesh we can create simple input/output pairs by sticking to hdf5 / use this tool to help build hdf5 files from inputs

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 71.24736% with 136 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (4c6ee8e) to head (b63a823).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...h/src/wmtk/components/multimesh/NamedMultiMesh.cpp 68.71% 56 Missing ⚠️
...h/src/wmtk/components/multimesh/MeshCollection.cpp 56.00% 22 Missing ⚠️
...nents/utils/wmtk/components/utils/PathResolver.cpp 67.24% 19 Missing ⚠️
applications/convert/main.cpp 87.25% 13 Missing ⚠️
...ts/output/wmtk/components/output/OutputOptions.cpp 55.55% 8 Missing ⚠️
...omponents/output/wmtk/components/output/output.cpp 0.00% 8 Missing ⚠️
...mponents/input/src/wmtk/components/input/input.cpp 76.00% 6 Missing ⚠️
...s/input/src/wmtk/components/input/InputOptions.cpp 72.72% 3 Missing ⚠️
...s/input/src/wmtk/components/input/InputOptions.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   76.62%   76.77%   +0.14%     
==========================================
  Files         463      466       +3     
  Lines       23035    23374     +339     
  Branches     2580     2620      +40     
==========================================
+ Hits        17651    17945     +294     
- Misses       5373     5418      +45     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 76.77% <71.24%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,7 @@
{
"tests": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need tests for this

@mtao mtao merged commit 6ca2e12 into main Nov 16, 2024
9 checks passed
@mtao mtao deleted the mtao/multimesh_naming_to_multimesh_component branch November 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants