Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiacheng/cdt opt application #837

Merged
merged 14 commits into from
Nov 8, 2024
Merged

Jiacheng/cdt opt application #837

merged 14 commits into from
Nov 8, 2024

Conversation

JcDai
Copy link
Collaborator

@JcDai JcDai commented Nov 4, 2024

cdt optimization using wildmeshing3d

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 64.38356% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c374150). Learn more about missing BASE report.
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/wmtk/invariants/Swap2dEdgeLengthInvariant.cpp 0.00% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage        ?   76.62%           
=======================================
  Files           ?      463           
  Lines           ?    23035           
  Branches        ?     2580           
=======================================
  Hits            ?    17651           
  Misses          ?     5373           
  Partials        ?       11           
Flag Coverage Δ
wildmeshing 76.62% <64.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JcDai JcDai requested review from mtao, teseoch and daniel-zint November 5, 2024 14:13
Copy link
Contributor

@daniel-zint daniel-zint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments on code structure. But please, do me the favor and add some documentation.

@@ -0,0 +1,425 @@
#include "cdt_optimization.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for this to be its own component? Should this be used by other components or applications? If not, it is cleaner to keep it directly in the application.

(We also created components for shortest-edge collapse, which actually doesn't make sense. I'll remove that component when I have some spare time)


namespace wmtk::components {

std::shared_ptr<Mesh> cdt_optimization(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really not a fan of having so many input parameters. It would be cleaner if you create a struct instead. An example can be found here.
But even if you stick to the many parameters style, add DOCUMENTATION!!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this component is removed now :)

@JcDai JcDai merged commit 4c6ee8e into main Nov 8, 2024
8 of 9 checks passed
@JcDai JcDai deleted the jiacheng/cdt-opt-component branch November 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants