-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dzint/tetwild msh converter #851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure - this is very similar to an application i have lying around in my branch called "convert" - we should discuss merging the two at some point. it does this functionality but i got stuck writing a generic but simple cmdline interface for it
if (m_enabled[3]) vtm.add_dataset("tets", "mesh", filename.string() + "_tets.vtu"); | ||
|
||
vtm.save(filename.string() + ".vtm"); | ||
if (m_enabled[0] + m_enabled[1] + m_enabled[2] + m_enabled[3] > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we shortcircuit writing at the beginning of this function with a return instead of down here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. This is just to avoid writing the additional VTM file. We still want all the VTUs to be written.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 77.06% 76.85% -0.22%
==========================================
Files 484 485 +1
Lines 24050 24119 +69
Branches 2694 2702 +8
==========================================
+ Hits 18535 18537 +2
- Misses 5504 5571 +67
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.