Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dzint/tetwild msh converter #851

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Dzint/tetwild msh converter #851

merged 2 commits into from
Jan 11, 2025

Conversation

daniel-zint
Copy link
Contributor

No description provided.

@daniel-zint daniel-zint requested review from teseoch, mtao and JcDai January 10, 2025 21:33
Copy link
Collaborator

@mtao mtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - this is very similar to an application i have lying around in my branch called "convert" - we should discuss merging the two at some point. it does this functionality but i got stuck writing a generic but simple cmdline interface for it

if (m_enabled[3]) vtm.add_dataset("tets", "mesh", filename.string() + "_tets.vtu");

vtm.save(filename.string() + ".vtm");
if (m_enabled[0] + m_enabled[1] + m_enabled[2] + m_enabled[3] > 1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we shortcircuit writing at the beginning of this function with a return instead of down here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean. This is just to avoid writing the additional VTM file. We still want all the VTUs to be written.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 11.84211% with 67 lines in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (1107b6b) to head (55263cc).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...twild_msh_converter/tetwild_msh_converter_main.cpp 0.00% 67 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   77.06%   76.85%   -0.22%     
==========================================
  Files         484      485       +1     
  Lines       24050    24119      +69     
  Branches     2694     2702       +8     
==========================================
+ Hits        18535    18537       +2     
- Misses       5504     5571      +67     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 76.85% <11.84%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-zint daniel-zint merged commit 958ba69 into main Jan 11, 2025
8 of 9 checks passed
@daniel-zint daniel-zint deleted the dzint/tetwild_msh_converter branch January 11, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants