-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ids public. #853
Make ids public. #853
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 76.85% 76.93% +0.08%
==========================================
Files 485 485
Lines 24119 24089 -30
Branches 2702 2714 +12
==========================================
- Hits 18537 18534 -3
+ Misses 5571 5544 -27
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete tupleinspector but other than that lgtm
By making the
Tuple
IDs public, all thefriend
stuff in there could be removed. I had to touch a lot of files because of that but, I think the code is cleaner now.