Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ids public. #853

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Make ids public. #853

merged 9 commits into from
Feb 13, 2025

Conversation

daniel-zint
Copy link
Contributor

By making the Tuple IDs public, all the friend stuff in there could be removed. I had to touch a lot of files because of that but, I think the code is cleaner now.

@daniel-zint daniel-zint requested a review from mtao January 29, 2025 21:59
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 76.08696% with 33 lines in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (958ba69) to head (9d9d843).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/wmtk/multimesh/utils/MapValidator.cpp 0.00% 15 Missing ⚠️
src/wmtk/multimesh/MultiMeshManager.cpp 40.00% 6 Missing ⚠️
...rc/wmtk/multimesh/utils/tuple_map_attribute_io.cpp 0.00% 4 Missing ⚠️
...ions/internal/CollapseAlternateFacetOptionData.cpp 0.00% 2 Missing ⚠️
...tk/operations/internal/SplitAlternateFacetData.cpp 66.66% 2 Missing ⚠️
src/wmtk/EdgeMesh.cpp 90.90% 1 Missing ⚠️
src/wmtk/TriMesh.cpp 88.88% 1 Missing ⚠️
...operations/internal/CollapseAlternateFacetData.cpp 0.00% 1 Missing ⚠️
src/wmtk/utils/TupleCellLessThanFunctor.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   76.85%   76.93%   +0.08%     
==========================================
  Files         485      485              
  Lines       24119    24089      -30     
  Branches     2702     2714      +12     
==========================================
- Hits        18537    18534       -3     
+ Misses       5571     5544      -27     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 76.93% <76.08%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtao mtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete tupleinspector but other than that lgtm

@daniel-zint daniel-zint merged commit d81f349 into main Feb 13, 2025
9 checks passed
@daniel-zint daniel-zint deleted the dzint/public_id branch February 13, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants