update signals for shell 3.18 #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,9 +3,10 @@ | |||
| "description": "Removes the title bar on maximised windows.\n Based on Pixel Saver (use Window Buttons to get the buttons (you can configure them then)\n You should be able to use the original Maximus extension if you have 3.4 or 3.6\nPlease report bugs on the github issues page: https://github.com/wilfm/GnomeExtensionMaximusTwo/issues\nNote you need xprop installed for this to work - see the github page for help with which package to install.", | |||
| "name": "Maximus Two", | |||
| "shell-version": [ | |||
| "3.16" | |||
| "3.16", | |||
There was a problem hiding this comment.
The size-change signal is not compatible with 3.16. It was added in 3.17.4. See: GNOME/gnome-shell@7305466
Since gnome-shell version 3.18, the 'maximize' and 'unmaximize' signals were replaced by a single 'size-change' signal. This is a port of commit 4eadd6eba8c2104a3b203ff86a115a1723e9b7d7 of the dash-to-dock extension.
|
It is now backwards compatible by adapting the signals to the current shell version. |
Depending on the shell version, the adequate signals can be used.
dffischer
added a commit
to dffischer/gnome-shell-extensions
that referenced
this pull request
Oct 28, 2015
This introduces shell version 3.18 compatibility. A pull request [1] is already filed, but not merged a few weeks since, so compatibility is shipped out via the fork until upstream merges. [1]: wilfm/GnomeExtensionMaximusTwo#41
dffischer
added a commit
to dffischer/gnome-shell-extensions
that referenced
this pull request
Apr 27, 2016
This introduces shell version 3.18 compatibility. A pull request [1] is already filed, but not merged a few weeks since, so compatibility is shipped out via the fork until upstream merges. [1]: wilfm/GnomeExtensionMaximusTwo#41
|
@wilfm Any chance in merging this? |
|
It would be useful to support 3.20 as well since it's in the wild (I'm using it). |
|
This repository seems quite inactive. I recommend using danielkza's fork instead, which currently seems most up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gnome-shell version 3.18, the 'maximize' and 'unmaximize' signals were replaced by a single 'size-change' signal. The extension seems to work without fixing these errors, but makes gnome-tweak-tool and extensions.gnome.org refuse to activate it.
This is an extension of #40. As I do not know whether it is possible to push commits onto a pull request that I do not own, I created this new pull request containing both changes.