Merge pull request #70 from crackcomm/push-lwwqokxolrmx

fix: close lsif file after writing
williamfzc · Nov 27, 2023 · b82aa07 · b82aa07
2 parents 6e0c5dc + 7f8d606
commit b82aa07
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/parser/api.go b/parser/api.go
@@ -66,9 +66,17 @@ func FromScipFile(scipFile string, srcDir string) (*object.SourceContext, error)
 	// still save this file for debug
 	lsifFile := filepath.Join(srcDir, "dump.lsif")
 	lsifWriter, err := os.OpenFile(lsifFile, os.O_WRONLY|os.O_CREATE, 0o666)
-	defer lsifWriter.Close()
+	if err != nil {
+		return nil, err
+	}
 
 	err = scip.WriteNDJSON(scip.ElementsToJsonElements(lsifIndex), lsifWriter)
+	if err != nil {
+		_ = lsifWriter.Close()
+		return nil, err
+	}
+
+	err = lsifWriter.Close()
 	if err != nil {
 		return nil, err
 	}