Matrix bridge #46

austinhuang0131 · 2024-02-03T23:25:10Z

gotta get it out of proof of concept

to matrix
- create
- update
- delete
- profile
from matrix
- create
- update
- delete
- profile
formats
- text
- attachments
- embed (to matrix only; convert to html)

on joining matrix room, check if either the room is public or the bot has invite permission

* fix name * fix localpart reservation and request * add appserviceUrl option (a web server where Matrix homeserver should send messages to) * remove encryption

…idging

williamhorning

So far, this all looks pretty good, and I really appreciate the fact that someone's actually taking a look at Matrix support. There're a few nitpicky things I've got but overall this is great!

williamhorning · 2024-02-04T15:22:58Z

packages/bolt-matrix/mod.ts

@@ -31,23 +31,6 @@ export default class MatrixPlugin extends BoltPlugin {
 			homeserverUrl: this.config.homeserverUrl,
 			domain: this.config.domain,
 			registration: this.config.reg_path,
-			bridgeEncryption: {


Is there any reason to remove all the encryption code? I'd prefer it if bolt-matrix supported encrypted rooms but if there's a reason I guess that's fine

because it doesn't launch on my end with it, i might revisit it in the future, but almost all matrix-appservice-${platform} don't have encryption

ah okay, i guess we could go back to that in the future then

packages/bolt-matrix/events.ts

packages/bolt-matrix/mod.ts

Co-authored-by: William Horning <[email protected]>

This reverts commit 4f971cb. simply put, it doesn't work

williamhorning

this all looks pretty nice so far but could you make a new PR with the changes to bolt-revolt and bolt/lib? i want to avoid future merge conflicts if possible and that’d really help

packages/bolt-matrix/deps.ts

austinhuang0131 · 2024-02-05T13:39:05Z

remind me to cherrypick later

Co-authored-by: William Horning <[email protected]>

austinhuang0131 · 2024-02-06T02:54:43Z

fair warning: i will have to let coreToMessage return a list of messages because matrix doesn't allow more than 1 attachments per message, or attachments with text

williamhorning · 2024-02-07T03:39:48Z

fair warning: i will have to let coreToMessage return a list of messages because matrix doesn't allow more than 1 attachments per message, or attachments with text

that should be fine and isn't out of the ordinary, bolt-guilded does that to allow for file uploads (at least on the 0.4.x-deno branch). also, you can split those functions into their own file if you want to

remind me to cherrypick later

cherry pick the stuff outside of bolt-matrix pls

williamhorning

just a few other things i noticed when looking at this.

also, when you get the chance, could you please cherry pick your changes to bolt-revolt and bolt/lib?

williamhorning · 2024-02-12T01:48:40Z

.gitignore

@@ -2,3 +2,4 @@
 /config
 /config.ts
 /docker-compose.yml
+db


Suggested change

db

/db

williamhorning · 2024-02-12T01:50:14Z

packages/bolt-matrix/events.ts

 ): Promise<BoltMessage<WeakEvent>> {
 	const sender = await intent.getProfileInfo(event.sender);
 	return {
 		author: {
 			username: sender.displayname || event.sender,
 			rawname: event.sender,
 			id: event.sender,
-			profile: sender.avatar_url
+			profile: `${sender.avatar_url.replace("mxc://", `${homeserverUrl}/_matrix/media/v3/thumbnail/`)}?width=96&height=96&method=scale`


Suggested change

profile: `${sender.avatar_url.replace("mxc://", `${homeserverUrl}/_matrix/media/v3/thumbnail/`)}?width=96&height=96&method=scale`

profile: `${sender.avatar_url.replace("mxc://", `${homeserverUrl}/_matrix/media/v3/thumbnail/`)}?width=96&height=96&method=scale`,

color: '#0DBD8B'

williamhorning · 2024-03-05T05:20:02Z

jsyk 0.5.5 was merged (see #44) so there're a few merge conflicts and public api changed but i can fix those for you if you'd like

Signed-off-by: Jersey <[email protected]>

williamhorning · 2024-03-05T17:50:08Z

see austinhuang0131#1

Merge branch 'main' into pr/austinhuang0131/46

williamhorning · 2024-03-26T17:55:43Z

thats not quite what i wanted to do, whoops

williamhorning · 2024-03-26T18:01:18Z

i couldn't actually redo this in a sane way so i guess ill try to find a way to implement embeds and stuff or you could make a pr

austinhuang0131 · 2024-03-26T18:03:46Z

to matrix

in principle embeds is just converting to some html that looks similar. for allowed tags see https://spec.matrix.org/v1.10/client-server-api/#mroommessage-msgtypes

attachments would be more complicated since it requires uploading first, then attaching the mxc to the message. for custom emotes it'd also need to work the same way, but you'll need to use some db to store emoji-to-mxc mappings.

from matrix

html? good luck converting that

images? use the download url on the homeserver

r3k2 · 2024-03-26T19:03:32Z

I think when you merge by mistake you closed the tied issues :) I saw the email and was all happy! Only to come here and see it was a mistake :D :D cheers.

austinhuang0131 added 2 commits February 3, 2024 23:21

fix(bolt-matrix): fix setup procedure

df1e8d0

* fix name * fix localpart reservation and request * add appserviceUrl option (a web server where Matrix homeserver should send messages to) * remove encryption

fix(bolt-matrix): convert mxc uri to thumbnail endpoint for avatar br…

ca9a53c

…idging

williamhorning marked this pull request as ready for review February 3, 2024 23:53

austinhuang0131 marked this pull request as draft February 3, 2024 23:56

williamhorning reviewed Feb 4, 2024

View reviewed changes

williamhorning added enhancement New feature or request 0.5.x new platform matrix epic labels Feb 4, 2024

austinhuang0131 and others added 10 commits February 4, 2024 16:32

refactor(bolt-matrix): homeserverUrl in avatar

4f971cb

Co-authored-by: William Horning <[email protected]>

fix(bolt-matrix): regex pattern for bridge puppets

bf2d142

Co-authored-by: William Horning <[email protected]>

fix(bolt-matrix): syntax

37becfc

Merge branch 'williamhorning:main' into matrix

3d537ef

Revert "refactor(bolt-matrix): homeserverUrl in avatar"

5488466

This reverts commit 4f971cb. simply put, it doesn't work

chore(bolt-matrix): ignore db

85e094e

fix(bolt-revolt): fix regression due to 040839c

0cff1f8

fix: deletion logic

3bf7ac6

feat(bolt-matrix): deletion

8d6dc72

refactor: separate duplication check and original message check

acda0cd

austinhuang0131 force-pushed the matrix branch from d3dafe6 to acda0cd Compare February 4, 2024 21:14

austinhuang0131 added 3 commits February 4, 2024 16:32

fix(bolt-matrix): edit

2ce6947

fix(bolt-revolt): display name

12febf3

feat(bolt-matrix): avatar update

aff713c

williamhorning reviewed Feb 5, 2024

View reviewed changes

packages/bolt-matrix/deps.ts Outdated Show resolved Hide resolved

refactor(bolt-matrix): buffer import

5c71723

Co-authored-by: William Horning <[email protected]>

williamhorning reviewed Feb 12, 2024

View reviewed changes

Merge branch 'main' into pr/austinhuang0131/46

faad273

Signed-off-by: Jersey <[email protected]>

austinhuang0131 and others added 2 commits March 5, 2024 17:51

Merge pull request #1 from williamhorning/matrix-0-5-x-merge

b7eab78

Merge branch 'main' into pr/austinhuang0131/46

Merge branch 'main' into matrix

b67ea7c

williamhorning mentioned this pull request Mar 14, 2024

Matrix #19

Open

williamhorning linked an issue Mar 14, 2024 that may be closed by this pull request

Matrix #19

Open

williamhorning mentioned this pull request Mar 16, 2024

redo a lot of the structure of core #58

Merged

25 tasks

williamhorning merged commit fe91041 into williamhorning:main Mar 26, 2024

williamhorning mentioned this pull request Mar 26, 2024

Revert "Matrix bridge" #60

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Matrix bridge #46

Matrix bridge #46

austinhuang0131 commented Feb 3, 2024 •

edited

Loading

williamhorning left a comment

williamhorning Feb 4, 2024

austinhuang0131 Feb 4, 2024

williamhorning Feb 5, 2024

williamhorning left a comment

austinhuang0131 commented Feb 5, 2024

austinhuang0131 commented Feb 6, 2024

williamhorning commented Feb 7, 2024 •

edited

Loading

williamhorning left a comment

williamhorning Feb 12, 2024

williamhorning Feb 12, 2024

williamhorning commented Mar 5, 2024

williamhorning commented Mar 5, 2024

williamhorning commented Mar 26, 2024

williamhorning commented Mar 26, 2024

austinhuang0131 commented Mar 26, 2024 •

edited

Loading

r3k2 commented Mar 26, 2024

	profile: `${sender.avatar_url.replace("mxc://", `${homeserverUrl}/_matrix/media/v3/thumbnail/`)}?width=96&height=96&method=scale`
	profile: `${sender.avatar_url.replace("mxc://", `${homeserverUrl}/_matrix/media/v3/thumbnail/`)}?width=96&height=96&method=scale`,
	color: '#0DBD8B'

Matrix bridge #46

Matrix bridge #46

Conversation

austinhuang0131 commented Feb 3, 2024 • edited Loading

williamhorning left a comment

Choose a reason for hiding this comment

williamhorning Feb 4, 2024

Choose a reason for hiding this comment

austinhuang0131 Feb 4, 2024

Choose a reason for hiding this comment

williamhorning Feb 5, 2024

Choose a reason for hiding this comment

williamhorning left a comment

Choose a reason for hiding this comment

austinhuang0131 commented Feb 5, 2024

austinhuang0131 commented Feb 6, 2024

williamhorning commented Feb 7, 2024 • edited Loading

williamhorning left a comment

Choose a reason for hiding this comment

williamhorning Feb 12, 2024

Choose a reason for hiding this comment

williamhorning Feb 12, 2024

Choose a reason for hiding this comment

williamhorning commented Mar 5, 2024

williamhorning commented Mar 5, 2024

williamhorning commented Mar 26, 2024

williamhorning commented Mar 26, 2024

austinhuang0131 commented Mar 26, 2024 • edited Loading

to matrix

from matrix

r3k2 commented Mar 26, 2024

austinhuang0131 commented Feb 3, 2024 •

edited

Loading

williamhorning commented Feb 7, 2024 •

edited

Loading

austinhuang0131 commented Mar 26, 2024 •

edited

Loading