Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are changing the concept of a
SortFunction
the unit tests have to change with it. This means that rather than comparing the timing we would compare the weights returned by theSortFunction
.However, this changes the concept of the unit tests entirely so we also need to add in unit tests for the
TimingFunction
's as well. To make sure that the refactor returns the same values, we would also need a combination of unit tests. This means the sort function would have to return the same values if we passed the weights into a standard timing function.