Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/click-command #25

Closed
wants to merge 10 commits into from
Closed

Conversation

exincore
Copy link

@exincore exincore commented Mar 11, 2022

Click Command

What?
  • Run a command when the extension icon is clicked
Why?
How?
  • panelMenuButton.js Run a command through GLib.spawn_command_line_async when clicked
  • prefs.js et al. Add setting and text box for the command

Run command on click

@exincore
Copy link
Author

exincore commented Mar 12, 2022

Standby as I unfudge my repository.

@exincore exincore closed this Mar 12, 2022
This reverts commit e0b356f, reversing
changes made to 9f23f99.
@exincore exincore reopened this Mar 12, 2022
@win0err
Copy link
Owner

win0err commented Mar 14, 2022

Hello! Thank you for the PR! Looks awesome!

I have a question: have you tested it in the following GNOME Shell versions: 3.38, 40, 41?

@exincore exincore closed this Mar 15, 2022
@exincore exincore closed this Mar 15, 2022
@exincore
Copy link
Author

Oops, I did not mean to do that.

I have a question: have you tested it in the following GNOME Shell versions: 3.38, 40, 41?

It seems to function on 40 and 3.38 but I have not done anything extensive.

@exincore exincore reopened this Mar 15, 2022
@win0err win0err modified the milestones: 20, v20 Mar 22, 2022
@exincore exincore marked this pull request as ready for review September 4, 2022 22:31
@win0err
Copy link
Owner

win0err commented Oct 3, 2022

@exincore, sorry it wasn't merged.
The same functionality has been released in version 20: see #32. I'm closing the PR.

Many thanks for the PR! I'm waiting for the really cool feature in #24!

@win0err win0err closed this Oct 3, 2022
@jack23247
Copy link

@win0err May I vouch for this PR to be reopened? The functionality implemented here is different by the behavior introduced in version 20. Namely, this PR allows:

  • The user to specify a custom command, which currently does not seem to be possible
  • The command to be run by left-clicking on the widget. Currently by doing that, the drop-down menu is presented instead.

It would be interesting to combine the functionality of this PR with what is currently possible in runcat 21 by allowing the user to choose the default behavior when left-clicking, specifying the executable they want to launch and customizing the text presented in the drop-down menu (which would still be accessible by right-clicking).

@win0err
Copy link
Owner

win0err commented Mar 21, 2023

@win0err May I vouch for this PR to be reopened? The functionality implemented here is different by the behavior introduced in version 20. Namely, this PR allows:

  • The user to specify a custom command, which currently does not seem to be possible
  • The command to be run by left-clicking on the widget. Currently by doing that, the drop-down menu is presented instead.

It would be interesting to combine the functionality of this PR with what is currently possible in runcat 21 by allowing the user to choose the default behavior when left-clicking, specifying the executable they want to launch and customizing the text presented in the drop-down menu (which would still be accessible by right-clicking).

Ok, I've added the feature request to backlog. Thank you!

@jack23247
Copy link

You're welcome, and thank you for considering my suggestion. Keep up the good work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants