Support Redoc options #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyvanderaerden
changed the title
wingyplus
reviewed
Jan 6, 2023
lib/plug/redoc_ui.ex
Outdated
Comment on lines
111
to
116
| Enum.reduce(opts, [], fn {key, value}, acc -> | ||
| case Enum.member?(@redoc_options, key) do | ||
| true -> [{to_kebab_case(key), value} | acc] | ||
| false -> acc | ||
| end | ||
| end) |
There was a problem hiding this comment.
This could be done by using Keyword.take/2:
Keyword.take(opts, @redoc_options)
|> Enum.map(fn {key, value} -> {to_kebab_case(key), value} end)There was a problem hiding this comment.
Oh, that's much better!
wingyplus
reviewed
Jan 10, 2023
| @impl true | ||
| def init(opts) do | ||
| spec_url = Keyword.fetch!(opts, :spec_url) |
There was a problem hiding this comment.
I think this would cause breaking change due to spec_url is missing. We should warn it and merge to redoc_opts if it's set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all options as described here: https://github.com/Redocly/redoc#redoc-options-object.
Not sure if this is the way you want to go but this is a fast way and easy to do so.
TODO
See all available options: REDOC_LINK)?Related #7.