Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(token): Speed up 'take_until' for str/char #378

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Dec 4, 2023

Before/after (with simd)

find_slice/byte/empty   time:   [8.6164 ns 9.0722 ns 9.5994 ns]
                        change: [-43.031% -39.731% -35.814%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/empty  time:   [8.9148 ns 9.4395 ns 9.9990 ns]
                        change: [-40.889% -36.871% -32.492%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/start   time:   [349.03 ns 382.08 ns 418.18 ns]
                        change: [-66.578% -63.083% -59.659%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/start  time:   [621.33 ns 662.95 ns 707.40 ns]
                        change: [-55.891% -51.971% -47.614%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/medium  time:   [535.01 ns 560.18 ns 586.97 ns]
                        change: [-68.347% -65.802% -62.864%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/medium time:   [681.00 ns 725.15 ns 772.02 ns]
                        change: [-58.167% -54.656% -50.939%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/large   time:   [12.233 µs 12.845 µs 13.494 µs]
                        change: [-97.200% -96.959% -96.698%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/large  time:   [12.739 µs 13.314 µs 13.912 µs]
                        change: [-91.483% -90.773% -90.011%] (p = 0.00 < 0.05)
                        Performance has improved.

epage added 3 commits December 4, 2023 14:49
Before/after (with simd)
```
find_slice/byte/empty   time:   [8.6164 ns 9.0722 ns 9.5994 ns]
                        change: [-43.031% -39.731% -35.814%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/empty  time:   [8.9148 ns 9.4395 ns 9.9990 ns]
                        change: [-40.889% -36.871% -32.492%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/start   time:   [349.03 ns 382.08 ns 418.18 ns]
                        change: [-66.578% -63.083% -59.659%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/start  time:   [621.33 ns 662.95 ns 707.40 ns]
                        change: [-55.891% -51.971% -47.614%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/medium  time:   [535.01 ns 560.18 ns 586.97 ns]
                        change: [-68.347% -65.802% -62.864%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/medium time:   [681.00 ns 725.15 ns 772.02 ns]
                        change: [-58.167% -54.656% -50.939%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/byte/large   time:   [12.233 µs 12.845 µs 13.494 µs]
                        change: [-97.200% -96.959% -96.698%] (p = 0.00 < 0.05)
                        Performance has improved.
find_slice/slice/large  time:   [12.739 µs 13.314 µs 13.912 µs]
                        change: [-91.483% -90.773% -90.011%] (p = 0.00 < 0.05)
                        Performance has improved.
```
src/stream/mod.rs Fixed Show fixed Hide fixed
src/stream/mod.rs Fixed Show fixed Hide fixed
src/stream/mod.rs Fixed Show fixed Hide fixed
src/stream/mod.rs Fixed Show fixed Hide fixed
@coveralls
Copy link

coveralls commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7092941784

  • 4 of 14 (28.57%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 44.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stream/mod.rs 4 14 28.57%
Files with Coverage Reduction New Missed Lines %
src/stream/mod.rs 2 30.51%
Totals Coverage Status
Change from base Build 7091807290: 0.3%
Covered Lines: 1224
Relevant Lines: 2780

💛 - Coveralls

benches/find_slice.rs Fixed Show fixed Hide fixed
benches/find_slice.rs Fixed Show fixed Hide fixed
@epage epage merged commit 592a4a3 into winnow-rs:main Dec 4, 2023
@epage epage deleted the slice branch December 4, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants